Modify

Opened 5 weeks ago

Closed 5 weeks ago

#17630 closed enhancement (fixed)

building:part=* and building=* on the same element makes no sense

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: template_report building Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. Create closed way
  2. add building:part=yes
  3. add building=yes
  4. Run validator

What is the expected result?

Validator complains, as building part is for part of the building.

Either building=* tag was added incorrectly (as way of mapping for renderer) or this is entire building and building:part is not needed.

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

39k+ affected objects - see https://taginfo.openstreetmap.org/keys/building:part#combinations

inspired by https://github.com/openstreetmap/iD/issues/6204#issuecomment-485016991 comment

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-04-03 00:33:43 +0200 (Wed, 03 Apr 2019)
Build-Date:2019-04-03 01:30:50
Revision:14954
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14954 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 434 MB / 869 MB (83 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ buildings_tools (34904)
+ continuosDownload (82)
+ imagery_offset_db (34867)
+ measurement (34867)
+ reverter (34961)
+ todo (30306)

Validator rules:
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
+ ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (0)

Change History (4)

comment:1 Changed 5 weeks ago by mkoniecz

Description: modified (diff)

comment:2 Changed 5 weeks ago by Don-vip

Keywords: building added

comment:3 Changed 5 weeks ago by Klumbumbus

Milestone: 19.04

comment:4 Changed 5 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15004/josm:

  • see #17567 - make validator warnings more comprehensible
  • fix #17630 - warn about building:part=* together with building=*
  • fix #17593 - warn about sport=football

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.