Modify

Opened 2 years ago

Closed 2 years ago

#17540 closed defect (fixed)

[Patch] created_by is not changed when reverting multiple changesets

Reported by: GerdP Owned by: GerdP
Priority: normal Milestone:
Component: Plugin reverter Version:
Keywords: template_report Cc: simon04

Description

What steps will reproduce the problem?

  1. Revert multiple changesets
  2. Click upload
  3. Click continue upload if validator complains
  4. Click tab "Tags of the new changeset", note that created_by doesn't mention reverter
  5. Cancel the upload

What is the expected result?

Like with a revert of a single cs the created_by tag in the new changeset should contain reverter
(or maybe better reverter/<version>, see #12400)

What happens instead?

created_by doesn't contain "reverter"

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2019-03-29 07:16:37
Revision:14939
Is-Local-Build:true

Identification: JOSM/1.5 (14939 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 541 MB / 1753 MB (383 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:51250, -Dfile.encoding=UTF-8]
Program arguments: [--debug]

Plugins:
+ FastDraw (34949)
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34904)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34946)
+ undelete (34919)
+ utilsplugin2 (34932)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (1)

17540.patch (2.1 KB) - added by GerdP 2 years ago.

Download all attachments as: .zip

Change History (4)

Changed 2 years ago by GerdP

Attachment: 17540.patch added

comment:1 Changed 2 years ago by GerdP

The attached patch fixes this problem and partly reverts #12400 to add the plugin version again.

comment:2 Changed 2 years ago by GerdP

Cc: simon04 added
Owner: changed from Upliner to GerdP
Status: newassigned

comment:3 Changed 2 years ago by GerdP

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.