Modify

Opened 7 months ago

Closed 5 months ago

#17526 closed enhancement (fixed)

[Patch] Search action dialog: New tooltip and more translations

Reported by: Hb--- Owned by: team
Priority: normal Milestone: 19.05
Component: Core Version:
Keywords: i18n english tooltip search Cc:

Description

The SearchAction dialog needs:

  1. A new tooltip "Add a button with this search expression to the toolbar." for the "add toolbar button" option.
  1. A better label "Options" for the option group currently titled as "Additional settings".
  1. A better label "Hints" for the central group currently titled as "Search hints".
  1. Translatable strings in the tooltip examples.

I18n effects are small, because "Options" and "Hints" are already translated. Dropped are "Additional settings" and "Search hints" as strings. New are all tooltip texts.

Attachments (6)

17526patch.diff (4.9 KB) - added by Hb--- 7 months ago.
untested patch
17526patch-ver2.diff (7.0 KB) - added by Hb--- 7 months ago.
untested patch for gui/dialogs/SearchDialog.java
17526patch-ver3-part-labels.patch (2.9 KB) - added by Hb--- 5 months ago.
Third version of patch, part: Labels
17526SearchDialog_ver3-examples.patch (3.4 KB) - added by Hb--- 5 months ago.
Third version of patch, second part: Examples
17526SearchDialog_ver3-tooltip.patch (1.2 KB) - added by Hb--- 5 months ago.
Third version of patch, third part: New Tooltip
SearchDialog-added-Context.patch (4.1 KB) - added by Hb--- 5 months ago.
This additional patch provides a "search string example" translation context to all new strings. The context can help to avoid translating key words.

Download all attachments as: .zip

Change History (17)

Changed 7 months ago by Hb---

Attachment: 17526patch.diff added

untested patch

comment:1 Changed 7 months ago by Don-vip

Keywords: tooltip search added
Milestone: 19.03
Summary: Search action dialog: New tooltip and more translations[Patch] Search action dialog: New tooltip and more translations

comment:2 Changed 7 months ago by Don-vip

The patch doesn't apply, can you please do it again?

Changed 7 months ago by Hb---

Attachment: 17526patch-ver2.diff added

untested patch for gui/dialogs/SearchDialog.java

comment:3 Changed 7 months ago by Don-vip

Milestone: 19.0319.04

comment:4 Changed 6 months ago by Don-vip

Milestone: 19.0419.05

comment:5 Changed 5 months ago by Don-vip

the patch applies but doesn't compile, please test.

comment:6 Changed 5 months ago by Don-vip

Owner: changed from team to Hb---
Status: newneedinfo

Changed 5 months ago by Hb---

Third version of patch, part: Labels

Changed 5 months ago by Hb---

Third version of patch, second part: Examples

Changed 5 months ago by Hb---

Third version of patch, third part: New Tooltip

comment:7 Changed 5 months ago by Hb---

Owner: changed from Hb--- to team
Status: needinfonew

The third version of the patch is split into three consecutive parts for easier testing.

comment:8 Changed 5 months ago by Don-vip

Thanks. Note: It's not easier. A single, proper SVN patch is the easiest for me (less work).

comment:9 Changed 5 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 15080/josm:

fix #17526 - Search action dialog: New tooltip and more translations (patch by Hb---)

comment:10 Changed 5 months ago by stoecker

Resolution: fixed
Status: closedreopened

I'm not sure all these changes are a good idea. Especially it is a bad idea to translate examples. The translators will e.g. translate "user:anonymous" with "nutzer:anonym" and that is simply wrong!

Last edited 5 months ago by stoecker (previous) (diff)

Changed 5 months ago by Hb---

This additional patch provides a "search string example" translation context to all new strings. The context can help to avoid translating key words.

comment:11 Changed 5 months ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 15090/josm:

fix #17526 - provide a "search string example" translation context to all new strings. The context can help to avoid translating key words. (patch by Hb---)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.