Opened 6 years ago
Closed 6 years ago
#17526 closed enhancement (fixed)
[Patch] Search action dialog: New tooltip and more translations
Reported by: | Hb--- | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 19.05 |
Component: | Core | Version: | |
Keywords: | i18n english tooltip search | Cc: |
Description
The SearchAction dialog needs:
- A new tooltip "Add a button with this search expression to the toolbar." for the "add toolbar button" option.
- A better label "Options" for the option group currently titled as "Additional settings".
- A better label "Hints" for the central group currently titled as "Search hints".
- Translatable strings in the tooltip examples.
I18n effects are small, because "Options" and "Hints" are already translated. Dropped are "Additional settings" and "Search hints" as strings. New are all tooltip texts.
Attachments (6)
Change History (17)
by , 6 years ago
Attachment: | 17526patch.diff added |
---|
comment:1 by , 6 years ago
Keywords: | tooltip search added |
---|---|
Milestone: | → 19.03 |
Summary: | Search action dialog: New tooltip and more translations → [Patch] Search action dialog: New tooltip and more translations |
by , 6 years ago
Attachment: | 17526patch-ver2.diff added |
---|
untested patch for gui/dialogs/SearchDialog.java
comment:3 by , 6 years ago
Milestone: | 19.03 → 19.04 |
---|
comment:4 by , 6 years ago
Milestone: | 19.04 → 19.05 |
---|
comment:6 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
by , 6 years ago
Attachment: | 17526patch-ver3-part-labels.patch added |
---|
Third version of patch, part: Labels
by , 6 years ago
Attachment: | 17526SearchDialog_ver3-examples.patch added |
---|
Third version of patch, second part: Examples
by , 6 years ago
Attachment: | 17526SearchDialog_ver3-tooltip.patch added |
---|
Third version of patch, third part: New Tooltip
comment:7 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | needinfo → new |
The third version of the patch is split into three consecutive parts for easier testing.
comment:8 by , 6 years ago
Thanks. Note: It's not easier. A single, proper SVN patch is the easiest for me (less work).
comment:10 by , 6 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I'm not sure all these changes are a good idea. Especially it is a bad idea to translate examples. The translators will e.g. translate "user:anonymous" with "nutzer:anonym" and that is simply wrong!
by , 6 years ago
Attachment: | SearchDialog-added-Context.patch added |
---|
This additional patch provides a "search string example" translation context to all new strings. The context can help to avoid translating key words.
untested patch