Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 4 weeks ago

#17469 closed enhancement (fixed)

Validator: add shortcut to zoom/move to next issue

Reported by: bagage Owned by: team
Priority: normal Milestone: 19.03
Component: Core Version:
Keywords: template_report Cc: Don-vip

Description

What's the use case?

When I run validator, I try to fix all errors/warnings that were triggered. Currently it's a bit cumbersome because:

  1. you have to open all categories one by one (not for long though #17295 :)), then double click on an issue to zoom on it.
  2. solve the issue
  3. repeat step 1-2 until you have treated all issues

I personally modified my workflow as follow:

  1. select all errors in the list
  2. then use button "select" which selects items on the map
  3. then I add them in todo plugin
  4. double click first item in the todolist
  5. fix it
  6. use todo plugin feature "mark as done". It then automatically selects next item and zoom on it.

It's much better IMHO. But maybe this behavior could be implemented directly in the validation list, eg:

  1. Have a shortcut to zoom on first error/warning
  2. Have another shortcut to mark the current error/warning as treated (or skipped). This would automatically moves to next item. Maybe items considered as treated could have a checkmark or similar to see what items are left to treat?

An alternative would be somehow a shortcut to fill the todo plugin list directly from the validator?

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2019-03-16 11:06:26
Revision:14887
Is-Local-Build:true

Identification: JOSM/1.5 (14887 SVN fr) Linux Debian GNU/Linux buster/sid
Memory Usage: 1645 MB / 4436 MB (1228 MB allocated, but free)
Java version: 1.8.0_191-8u191-b12-2-b12, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u191-b12-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (34867)
+ HouseNumberTaggingTool (34867)
+ OpeningHoursEditor (34867)
+ PicLayer (34867)
+ buildings_tools (34904)
+ conflation (0.6.2)
+ jts (34524)
+ poly (34867)
+ scripting (30794)
+ terracer (34867)
+ todo (30306)
+ utilsplugin2 (34915)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- W: Cannot start IPv4 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- W: Cannot start IPv6 remotecontrol https server on port 8112: Keystore was tampered with, or password was incorrect
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=500
- W: org.openstreetmap.josm.io.OsmApiException: ResponseCode=500
- W: org.openstreetmap.josm.io.OsmApiException: ResponseCode=500
- W: Region [WMS_BLOCK_v2] Resetting cache
- W: Region [WMTS_BLOCK_v2] Resetting cache

Attachments (1)

17469-shortcut.patch (2.0 KB) - added by GerdP 5 weeks ago.
Allow to bind shortcut to "Ignore for now" action

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 weeks ago by GerdP

Resolution: fixed
Status: newclosed

In 14889/josm:

fix #17469: Add action "Remove" to right click menu.
The action removes the corresponding error from the tree. The error is ignored until the validator is executed again.

comment:2 Changed 5 weeks ago by GerdP

Please reopen this ticket if this simple solution doesn't solve the problem.

comment:3 Changed 5 weeks ago by GerdP

In 14894/josm:

see #17469: Change action name "Remove" to "Ignore for now" else one might assume that the action removes the OSM objects.

comment:4 Changed 5 weeks ago by bagage

Thanks GerdP for the quick patch! It seems that this action is not key bindable though, is it? Same for "Zoom on issue". If both were bindable I think this solution would be totally ideal!

comment:5 Changed 5 weeks ago by GerdP

The "Zoom to problem" action is already bound to key "6".
It is quite difficult to find new key bindings because most are already in use, see
https://josm.openstreetmap.de/wiki/DevelopersGuide/ShortcutsList

comment:6 Changed 5 weeks ago by bagage

Indeed there are already a bunch of shortcuts. But isn't it possible to make it bindable, with no default binding? I'd happily remove another personally for that.

Changed 5 weeks ago by GerdP

Attachment: 17469-shortcut.patch added

Allow to bind shortcut to "Ignore for now" action

comment:7 Changed 5 weeks ago by GerdP

Cc: Don-vip added
Resolution: fixed
Status: closedreopened

I think you have to have the validator panel open before you can change the shortcut. For me it is changed to Ctrl+Alt+F2.
@Vincent I'd prefer to enable/disable the command depending on the context but I didn't find out how. Please let me know if you think this patch can cause problems.

comment:8 Changed 5 weeks ago by GerdP

In 14912/josm:

see #17469: add shortcut Shift+Minus for "Ignore for now" action

comment:9 Changed 5 weeks ago by GerdP

Resolution: fixed
Status: reopenedclosed

I think Shift+Minus is quite intuitve for a "remove action" and it wasn't in use.

comment:10 Changed 5 weeks ago by GerdP

Milestone: 19.03

comment:11 Changed 4 weeks ago by GerdP

In 14931/josm:

see #17469: Fix memory leak: destroy JosmAction

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.