Modify

Opened 5 weeks ago

Closed 5 weeks ago

#17468 closed defect (fixed)

Validator produces wrong warning for misspelled tag key

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc: Klumbumbus

Description

What steps will reproduce the problem?

  1. Create closed way with tag land_Area=administrative
  2. Run Validator

What is the expected result?

Warning "Key 'land_Area' looks like 'land_Area'"

What happens instead?

Warning "Presets do not contain property key - Key 'land_Area' not in presets."

Please provide any additional information below. Attach a screenshot if possible.

See also #17444.
The comment in file ignoreTags.cfg says

; K:  the given tag will not produce a "tag not in presets" error, but it is 
;     used as dictionary entry for spell checking the given key.

and ignoreTags.cfg contains

K:land_area=administrative

The current code uses this entry only to spell check the tag value.
The entries starting with E: chould also be used to spell check keys.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-03 00:16:03 +0100 (Sun, 03 Mar 2019)
Build-Date:2019-03-02 23:16:53
Revision:14824
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14824 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 686 MB / 1820 MB (508 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-XX:StartFlightRecording=name=MyRecording2,settings=d:\dbg\gerd.jfc, -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true,dumponexitpath=e:\ld\perf_20190316_092115.jfr]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34904)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34917)
+ undelete (34919)
+ utilsplugin2 (34915)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (2)

17468.patch (7.9 KB) - added by GerdP 5 weeks ago.
17468-v2.patch (7.9 KB) - added by GerdP 5 weeks ago.
fix typo in words.cfg ignoreFiles.cfg -> ignoreTags.cfg

Download all attachments as: .zip

Change History (4)

Changed 5 weeks ago by GerdP

Attachment: 17468.patch added

Changed 5 weeks ago by GerdP

Attachment: 17468-v2.patch added

fix typo in words.cfg ignoreFiles.cfg -> ignoreTags.cfg

comment:1 Changed 5 weeks ago by GerdP

@Klumbumbus: Please review the changes to words.cfg and ignoreTags.cfg. Besides the changes proposed in #17444 I modified the comments and adedd an entry for barrier.
If I hear no complains I'll commit v2 on Monday.

comment:2 Changed 5 weeks ago by GerdP

Resolution: fixed
Status: newclosed

In 14897/josm:

fix #17468: Validator produces wrong warning for misspelled tag key

TODO: further improve words.cfg

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.