Modify

Opened 2 months ago

Last modified 4 weeks ago

#17370 needinfo enhancement

[PATCH] add deprecated tags from Osmose checks

Reported by: abalosc1 Owned by: abalosc1
Priority: normal Milestone: 19.04
Component: Core validator Version:
Keywords: Cc:

Description


Attachments (2)

deprecatedmapcss.patch (26.9 KB) - added by abalosc1 2 months ago.
translate deprecated warnings
deprecatedmapcss.2.patch (9.9 KB) - added by abalosc1 2 months ago.
removed wood, mdf, and dry cleaning from added osmose checks

Download all attachments as: .zip

Change History (9)

comment:1 Changed 2 months ago by abalosc1

Summary: add deprecated tags from Osmose checks[PATCH] add deprecated tags from Osmose checks

comment:2 Changed 2 months ago by Klumbumbus

Component: External ruleCore validator
Type: taskenhancement

comment:3 Changed 2 months ago by Don-vip

Milestone: 19.02

comment:4 Changed 2 months ago by Don-vip

Owner: changed from team to abalosc1
Status: newneedinfo

Can you please make sure messages are correctly translated by using this syntax?
throwWarning: tr("{0} is deprecated", "{0.tag}");

Changed 2 months ago by abalosc1

Attachment: deprecatedmapcss.patch added

translate deprecated warnings

comment:5 Changed 2 months ago by Klumbumbus

I'm not in favor to add checks, which are not really needed (for performance reasons). E.g.

  • man_made=mdf is used 5 times
  • amenity=dry_cleaning is used 3 times

and they were added only about once per year in the last years (see taghistory).

Also *[wood] produces double warnings with already existing wood=* warnings.

The changes with tr() messed up the patch file too.

comment:6 Changed 2 months ago by Don-vip

Milestone: 19.0219.03

Changed 2 months ago by abalosc1

Attachment: deprecatedmapcss.2.patch added

removed wood, mdf, and dry cleaning from added osmose checks

comment:7 Changed 4 weeks ago by Klumbumbus

Milestone: 19.0319.04

Modify Ticket

Change Properties
Set your email in Preferences
Action
as needinfo The owner will remain abalosc1.
as The resolution will be set.
to The owner will be changed from abalosc1 to the specified user.
to The owner will be changed from abalosc1 to the specified user.
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from abalosc1 to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.