Modify

Opened 6 months ago

Closed 5 weeks ago

#17370 closed enhancement (fixed)

[PATCH] add deprecated tags from Osmose checks

Reported by: abalosc1 Owned by: Klumbumbus
Priority: normal Milestone: 19.08
Component: Core validator Version:
Keywords: sotmfr2019 osmose Cc:

Description


Attachments (2)

deprecatedmapcss.patch (26.9 KB) - added by abalosc1 6 months ago.
translate deprecated warnings
deprecatedmapcss.2.patch (9.9 KB) - added by abalosc1 6 months ago.
removed wood, mdf, and dry cleaning from added osmose checks

Download all attachments as: .zip

Change History (20)

comment:1 Changed 6 months ago by abalosc1

Summary: add deprecated tags from Osmose checks[PATCH] add deprecated tags from Osmose checks

comment:2 Changed 6 months ago by Klumbumbus

Component: External ruleCore validator
Type: taskenhancement

comment:3 Changed 6 months ago by Don-vip

Milestone: 19.02

comment:4 Changed 6 months ago by Don-vip

Owner: changed from team to abalosc1
Status: newneedinfo

Can you please make sure messages are correctly translated by using this syntax?
throwWarning: tr("{0} is deprecated", "{0.tag}");

Changed 6 months ago by abalosc1

Attachment: deprecatedmapcss.patch added

translate deprecated warnings

comment:5 Changed 6 months ago by Klumbumbus

I'm not in favor to add checks, which are not really needed (for performance reasons). E.g.

  • man_made=mdf is used 5 times
  • amenity=dry_cleaning is used 3 times

and they were added only about once per year in the last years (see taghistory).

Also *[wood] produces double warnings with already existing wood=* warnings.

The changes with tr() messed up the patch file too.

comment:6 Changed 6 months ago by Don-vip

Milestone: 19.0219.03

Changed 6 months ago by abalosc1

Attachment: deprecatedmapcss.2.patch added

removed wood, mdf, and dry cleaning from added osmose checks

comment:7 Changed 5 months ago by Klumbumbus

Milestone: 19.0319.04

comment:8 Changed 4 months ago by Don-vip

Milestone: 19.0419.05

comment:9 Changed 4 months ago by Don-vip

There are still checks for very uncommon tags. The first one, aerialway=canopy, is used only 31 times. The second, amenity=abandoned is used only 1 time. I didn't check the others.

Please check them and only keep those who are frequently misused. For example anything with more than 500 uses.

comment:10 Changed 4 months ago by Don-vip

Milestone: 19.05

comment:11 Changed 3 months ago by Don-vip

@abalosc1: up

comment:12 Changed 3 months ago by Don-vip

Resolution: needinfo
Status: needinfoclosed

comment:13 Changed 7 weeks ago by Klumbumbus

Milestone: 19.07
Resolution: needinfo
Status: closedreopened

comment:14 Changed 7 weeks ago by Klumbumbus

Owner: changed from abalosc1 to Klumbumbus
Status: reopenednew

comment:15 Changed 7 weeks ago by Don-vip

Keywords: sotmfr2019 osmose added

comment:16 Changed 7 weeks ago by Don-vip

Milestone: 19.0719.08

Milestone renamed

comment:17 Changed 5 weeks ago by Klumbumbus

  • aerialway=canopy - usage too low
  • amenity=abandoned - usage too low
  • amenity=citymap_post - 102 out of 114 in the city of Warszawa
  • amenity=creche - usage too low
  • amenity=ev_charging - usage too low
  • amenity=charging - usage too low
  • amenity=fire_hydrant - warning already existing
  • amenity=garages - to be added
  • amenity=garage - to be added
  • amenity=nursery - unclear if by replacement with only amenity=kindergarten informatin get lost. Usage of additional tag nursery=yes is pretty low.
  • amenity=preschool - unclear if by replacement with only amenity=kindergarten informatin get lost. Usage of additional tag preschool=yes is pretty low.
  • amenity=real_estate - usage too low
  • office=real_estate - to be added
  • shop=real_estate - usage too low
  • amenity=sauna - warning already existing
  • amenity=winery - to be added, also shop=winery
  • amenity=youth_centre - to be added
  • amenity=youth_center - usage too low
  • bridge=arch - usage too low
  • bridge=beam - usage too low
  • bridge=humpback - usage too low
  • bridge=suspension - warning already existing
  • bridge=lift - usage too low
  • bridge=swing - warning already existing
  • bridge=pontoon - to be added
  • building:type - to be added
  • escalator - to be added
  • fenced - to be added
  • highway=abandoned - to be added
  • highway=minor - usage too low
  • historic_name - to be added
  • historic=museum - can be valid if the museum itself is a historic feature, see https://wiki.openstreetmap.org/wiki/Historic
  • landuse=field - to be added
  • leisure=beach - to be added
  • leisure=club - to be added
  • leisure=video_arcade - to be added
  • man_made=cooling - it seems there is no clear consensus, see man made=cooling tower wiki page history
  • man_made=hot_water_tank - usage too low
  • man_made=jetty - to be added
  • man_made=village_pump - to be added
  • man_made=water_tank - to be added
  • natural=moor - to be added
  • noexit=no - to be added
  • office=administrative - has an own ticket: #15614
  • power=underground_cable - usage too low
  • railway=preserved - while I personally would support the depracation it is controversial
  • shop=dive - to be added
  • shop=furnace - to be added
  • shop=moneylender - usage too low
  • sport=paragliding - to be added
  • tourism=bed_and_breakfast - to be added
Last edited 5 weeks ago by Klumbumbus (previous) (diff)

comment:18 Changed 5 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15262/josm:

fix #17370

  • deprecate amenity=garages, amenity=garage, office=real_estate, amenity=winery, shop=winery, amenity=youth_centre, bridge=pontoon, building:type, escalator, fenced, highway=abandoned, historic_name, landuse=field, leisure=beach, leisure=club, leisure=video_arcade, man_made=jetty, man_made=village_pump, man_made=water_tank, natural=moor, noexit=no, shop=dive, shop=furnace, sport=paragliding, tourism=bed_and_breakfast
  • add guest_house=*, community_centre=*, community_centre:for=*

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.