[PATCH] add combination checks based off KeepRight and Osmose

[abalosc1]

updated to include some combinations from osmose checks

[Don-vip]

In 14798/josm:

fix #17371 - add combination checks based off KeepRight and Osmose (patch by abalosc1, modified)

[Don-vip]

Thanks for the patch! :)

[aceman]

Wait, will e.g. cafes without 'operator' be reported now? Why is 'name' not enough?

[Klumbumbus]

Yes, this change needs some rework.

• these missing operator rules don't fit in warning level. I personally wouldn't even put them in info level. (e.g. currently only 3% of amenity=cafe have an operator tag)
• missing ele and denomination should be info level
• place without name is a bit risky as it may encourages fake names (​https://wiki.openstreetmap.org/wiki/Names#Name_is_the_name_only) atleast for place=islet (currently 19% of islets have a name tagged). On the other hand ​https://wiki.openstreetmap.org/wiki/Key:place says "Used to indicate that a particular location is known by a particular name", So I guess islets without name should be mapped without the place=islet tag and only by multipolygon or coastline? We have 178000 place=islet objects without name in our database and much likely on most cases not the name tag is missing but the place tag should be removed (as there doesn't exist a name). Then we need a better warning text.

[Don-vip]

In 14799/josm:

fix #17371 - rework combination checks

[Don-vip]

In 14800/josm:

see #17371 - fix file

[Klumbumbus]

Ticket #17374 has been marked as a duplicate of this ticket.

[abalosc1]

updated some to be info level warnings. removed place without name

[Klumbumbus]

It should already all be done.

[abalosc1]

Oh thanks, just looked at the fixes. The only thing that didn't get addressed is "denomination" is still under warning instead of info.

[Klumbumbus]

In 14818/josm:

see #17371 - downgrade place_of_worship without denomination warning to info level