Modify

Opened 12 days ago

Closed 10 days ago

Last modified 10 days ago

#17297 closed enhancement (fixed)

False positive: Unknown property value - Value 'reformed' for key 'denomination' is unknown, maybe 'reform' is meant?

Reported by: AnkEric Owned by: team
Priority: normal Milestone: 19.02
Component: Core validator Version:
Keywords: denomination Cc: Klumbumbus

Description

[religion=christian] + [denomination=reformed] is correct, however JOSM validation will set a 'Warning'.

Unknown property value - Value 'reformed' for key 'denomination' is unknown, maybe 'reform' is meant?

https://wiki.openstreetmap.org/wiki/Key:denomination
Christian denominations:
[religion=christian] + [denomination=reformed] is correct (Calvinism (Reformed))

This is 'just' a false positive and to be ignored.
However: 'correcting' this 'false positive' might result in a real error!

See: https://josm.openstreetmap.de/ticket/8877
Don-vip: "That's a huge list, I will only add for now the most used".
My suggestion:
If you cannot add the complete list (I can imagine), skip the validation. IMO that would also resolve.

To complicate the issue: [religion=jewish] + [denomination=reform] is also correct....
So this is not about - just - [denomination=*], but about [religion=*] + [denomination=*].

/AnkEric

Attachments (0)

Change History (10)

comment:1 Changed 12 days ago by AnkEric

Type: defectenhancement

comment:2 Changed 12 days ago by GerdP

I agree. The tag denomination=reformed is used much more often compared to denomination=reform, but both appear in the wiki.
The check that produces the message "Unknown property value - Value 'reformed' for key 'denomination' is unknown, maybe 'reform' is meant?" only looks for wrong spelling, it doesn't check the possible combinations. It simply uses all known values for denomination.
@Klumbumbus:
If I got that right we should better change the presets here, or should I just add K:denomination=reformed to the ignoretags.cfg?

comment:3 Changed 12 days ago by GerdP

Cc: Klumbumbus added

comment:4 Changed 12 days ago by Klumbumbus

Yes, we should add "reformed" to the church preset.

comment:5 Changed 12 days ago by GerdP

Please do it, I have no experience with presets.

comment:6 Changed 11 days ago by Klumbumbus

Milestone: 19.02

comment:7 Changed 11 days ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 14767/josm:

  • fix #17297, see #8877 - add wiki documented denominations >500 uses
  • fix #17298 - don't warn about "customer is not a valid restriction value"

comment:8 Changed 10 days ago by Don-vip

Resolution: fixed
Status: closedreopened

TagCheckerTest.testIgnoredTagsNotInPresets needs to be updated:

AssertionFailedError: [denomination=nondenominational, denomination=serbian_orthodox, denomination=united, denomination=nondenominational, denomination=nondenominational]
	at org.openstreetmap.josm.data.validation.tests.TagCheckerTest.testIgnoredTagsNotInPresets(TagCheckerTest.java:171)

comment:9 Changed 10 days ago by GerdP

Resolution: fixed
Status: reopenedclosed

In 14773/josm:

fix #17297: TagCheckerTest fails: remove entries from ignoretags which were added to presets in r14767

comment:10 Changed 10 days ago by Klumbumbus

Thanks for fixing. I often forget to check ignoretags.cfg

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.