Modify

Opened 18 months ago

Closed 4 weeks ago

Last modified 3 weeks ago

#17296 closed enhancement (fixed)

[PATCH] If there is a fixme and the fixme value is also a tag, we should ask if the fixme is fixed

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 20.07
Component: Core validator Version:
Keywords: mapcss fixme Cc:

Description (last modified by taylor.smock)

Example: way fixme=name name=Broadway -- the fixme may or may not be fixed.

The patch I uploaded throws a warning when an object is modified and fulfills the criteria while only throwing an informational warning if it has not been modified.

Note: I didn't see a good place to put the check in the preexisting files.

Attachments (1)

fixme.patch (993 bytes) - added by taylor.smock 18 months ago.

Download all attachments as: .zip

Change History (12)

Changed 18 months ago by taylor.smock

Attachment: fixme.patch added

comment:1 Changed 18 months ago by taylor.smock

Description: modified (diff)

comment:2 Changed 13 months ago by Don-vip

Keywords: fixme added

comment:3 Changed 4 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16775/josm:

fix #17296 - If the value of fixme is also a tag, ask if the fixme is fixed (patch by taylor.smock, modified)

comment:4 Changed 4 weeks ago by Klumbumbus

Milestone: 20.07

comment:5 Changed 4 weeks ago by Klumbumbus

In 16777/josm:

fix #17296 - support variant FIXME too

comment:6 Changed 4 weeks ago by taylor.smock

I'm sorry that I didn't have FIXME in the original patch. :(

Thanks for looking at this patch -- I had kind of forgotten about it.

comment:7 in reply to:  6 ; Changed 4 weeks ago by Klumbumbus

Replying to taylor.smock:

FIXME

Yeah, a bit annoying we have these duplicate tags in the database. However the number very slowly decreases:
https://taghistory.raifer.tech/#***/Fixme/&***/FIXME/&***/fixme/

Last edited 4 weeks ago by Klumbumbus (previous) (diff)

comment:8 in reply to:  7 ; Changed 3 weeks ago by skyper

It would be even better to use case insensitive regex to catch Fixme and other variants, as well.

Yesterday, I found a tag crossing=Fixme.

Replying to Klumbumbus:

Replying to taylor.smock:

FIXME

Yeah, a bit annoying we have these duplicate tags in the database. However the number very slowly decreases:
https://taghistory.raifer.tech/#***/Fixme/&***/FIXME/&***/fixme/

Thanks to iD deprecating a tag which is not deprecated and people modifying objects only to change FIXME to lower cases. Very annoying, especially with big relations.

comment:9 in reply to:  8 Changed 3 weeks ago by Klumbumbus

Replying to skyper:

It would be even better to use case insensitive regex to catch Fixme and other variants, as well.

I don't think thats possible with that syntax due to the tag() expressions. I think it is not needed anyway as the numbers of fixme variants other than fixme and FIXME are very low compared to these two.

comment:10 Changed 3 weeks ago by taylor.smock

I think it would require #17669 to be fixed at a minimum, with a caveat that as soon as a "group" becomes available, it is now available for following conditions. I don't know if this is already the case (its been awhile since I touched anything related to mapcss, including mapcss files).

comment:11 in reply to:  8 Changed 3 weeks ago by skyper

Replying to Klumbumbus:

Replying to skyper:

It would be even better to use case insensitive regex to catch Fixme and other variants, as well.

I don't think that's possible with that syntax due to the tag() expressions.

Need to use regexp_test() or regexp_match() which have the options for case-insensitive.

I think it is not needed anyway as the numbers of fixme variants other than fixme and FIXME are very low compared to these two.

So, keep it for now.

Yesterday, I found a tag crossing=Fixme.

Mmh, I get the common FIXMES informal warning. Here either more cases are tested or case-insensitive is in use.
Probably better to remove the tag (crossing in my case) completely and add a new tag with switched key - value, e.g. Fixme=crossing.

Last edited 3 weeks ago by skyper (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.