Add support for power=connection

[Penegal]

There happens that crossing power lines are connected with one another without any supporting pole or tower, such as on the attached picture. In this case, the lines share a node tagged power=connection, but JOSM has no support of this configuration: it has no such preset, and warns about power line nodes without power=(pole|tower). Could this preset be added and the relevant warning adapted to not show when the node is tagged power=connection?

[Penegal]

Example of connections

[francois.lacombe]

Nice one
power=connection haven't been reviewed yet.
It has been part of a huge (rejected) proposal in 2014 : ​https://wiki.openstreetmap.org/wiki/Proposed_features/Power_paths_refinement
Despite it is currently used about 1000 times, I'm not sure to add it as a preset.

Nevertheless, JOSM shouldn't warn users when two power=* lines connect each other.
The warning should raise if and only if the node is shared by both power and non-power objects or standalone in a single line.
We can find connection nodes with power=switch in substations for instance

Hope it helps

[Klumbumbus]

Replying to francois.lacombe:

I'm not sure to add it as a preset.

Is there a reason? The tag seems fine to me.

[francois.lacombe]

It is not currently documented on wiki.
Despite the idea sounds good, if there is no connection, then there should be no shared node between nodes.
connection=* (especially connection=no) is find to say that several lines sharing the same pole aren't connected.
Additional design should be done with those two tags.

I fully agree on the warning anyway

[Klumbumbus]

In 15088/josm:

• see #17034 - add icon proposals for connection nodes of power lines
• add svn:mime-type of images

[Klumbumbus]

Removing the milestone as first power=conection vs. connection=yes/no should be decided (not in this ticket).
I added 3 possible icons for later use to the nodist folder:

[francois.lacombe]

Thank you Klumbumbus

I'd be in favour of 3rd icon from your proposal
First two, with straight connections may let mapper think they refer to bundles link like here : ​https://wiki.openstreetmap.org/wiki/File:JP_Power_Wires_Fivefold.JPG

Regarding power=connection vs connection=* I think both should be valid, depending on the previous usage of power=* for another value (like poles)

[Hb---]

Replying to Klumbumbus:

In 15088/josm: ... add svn:mime-type of images

Please check images/data/imagery/photo.svg again. This icon needs 80% of the help browser screen and is currently not seen in the Imagery menu. The other svg images are also very larrge in the help browser.

[Klumbumbus]

Thats not related to this ticket. It is #15864.

[Hb---]

Comment 14 was not about the general issue, but only for some svg images which were changed last with r15088. They were initally uplodated for #16301 with r15049. Opening a new ticket seemed inappropriate.

Most oversized one is photo.svg, see screenshot. The osmbasedmap.svg seems also to large.

[skyper]

numbers are still low resp. minimal for power=connection and connection=*

Regarding power=connection my major concern is the missing wiki page.

[harahu]

Replying to skyper:

Regarding power=connection my major concern is the missing wiki page.

See: ​https://wiki.openstreetmap.org/wiki/Tag:power%3Dconnection

[Klumbumbus]

Ticket #21566 has been marked as a duplicate of this ticket.

[Klumbumbus]

I'm in favor of adding power=connection now. The wiki page is present and the number grows constantly. connection=* on the other hand has still a very low count.
I can do the peset and mappaint part, but someone else needs to adapt the validator test (i.e. don't warn about power=connection on power intersection nodes and adapt the warning message). This also interferes with the patch in #20716.

[skyper]

I think fixing the validator only requires to add connection to either POWER_TOWER_TAGS or POWER_ALLOWED_TAGS.

[GerdP]

gaben is working on a larger patch for PowerLines, see #20716

[harahu]

Replying to skyper:

I think fixing the validator only requires to add connection to either POWER_TOWER_TAGS or POWER_ALLOWED_TAGS.

I haven't looked at the code, so can't say whether what you suggest will have the desired effect or not, but I see some potential pitfalls to keep in mind.

One is that power=connection likely shouldn't be considered on par with tower or pole in all situations. For instance, it makes little sense on a single line. My understanding of the tag is that is should exclusively be present on line crossings.

So, if you replace a power=tower with a power=connection on a single line, that should probably raise a warning.

This would have the added benefit of catching issues caused by having a valid line crossing with a connection and then deleting one of the connected lines.

[gaben]

I removed most false warnings for power=connection in the validator, that's all for now. No patch yet. What else is needed?

[Klumbumbus]

Replying to gaben:

What else is needed?

I'm not sure whats best to commit it before, together of after #20716.

[gaben]

Can be done before, as just adding the "connection" string here silences the "Missing power tower/pole within power line" warning.

src/org/openstreetmap/josm/data/validation/tests/PowerLines.java

@@ -44 +44 @@
     static final Collection<String> BUILDING_STATION_TAGS = Arrays.asList("transformer_tower");
     /** Values for {@code power} key interpreted as allowed power items */
     static final Collection<String> POWER_ALLOWED_TAGS = Arrays.asList("switch", "transformer", "busbar", "generator", "switchgear",
-            "portal", "terminal", "insulator");
+            "portal", "terminal", "insulator", "connection");
 
     private final Set<Node> badConnections = new LinkedHashSet<>();
     private final Set<Node> missingTowerOrPole = new LinkedHashSet<>();

[gaben]

first idea

[gaben]

The initial patch contains the 3rd version and includes the operator tag which may be unnecessary. Also, an SVG cleanup is needed I think.

[Klumbumbus]

In 18324/josm:

fix #17034 - Add power=connection (partly patch by gaben, icon self created PD and CC0 licensed)

[gaben]

Ah nothing, please ignore.

[Don-vip]

Milestone renamed