Modify ↓

Opened 5 years ago

Last modified 5 years ago

#16954 new enhancement

[(tentative) PATCH] MainApplicationTest: fix for non-headless mode

Reported by: ris Owned by: team
Priority: minor Milestone:
Component: Unit tests Version:
Keywords: headless Cc:

Description

​https://github.com/openstreetmap/josm/pull/53

Here's a patch to fix MainApplicationTest for non-headless mode, but I'm not sure it should be applied. If you look at what it's mocking out, it seems to be mocking out largely error dialogs that are showing that the test is kinda broken. Should someone sit down and fix these tests to work in the way they were originally intended? Should be just apply this to get the non-headless tests passing and move on? Don't know.

Patch against r14412

Attachments (1)

v1-0001-MainApplicationTest-fix-for-non-headless-mode.patch​ (6.1 KB ) - added by ris 5 years ago.

Download all attachments as: .zip

Change History (2)

by ris, 5 years ago

Attachment: v1-0001-MainApplicationTest-fix-for-non-headless-mode.patch​ added

comment:1 by ris, 5 years ago

Hold back on this one anyway - having trouble on travis with it.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to ris.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.