Opened 6 years ago
Last modified 6 years ago
#16954 new enhancement
[(tentative) PATCH] MainApplicationTest: fix for non-headless mode
Reported by: | ris | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Unit tests | Version: | |
Keywords: | headless | Cc: |
Description
https://github.com/openstreetmap/josm/pull/53
Here's a patch to fix MainApplicationTest for non-headless mode, but I'm not sure it should be applied. If you look at what it's mocking out, it seems to be mocking out largely error dialogs that are showing that the test is kinda broken. Should someone sit down and fix these tests to work in the way they were originally intended? Should be just apply this to get the non-headless tests passing and move on? Don't know.
Patch against r14412
Attachments (1)
Change History (2)
by , 6 years ago
Attachment: | v1-0001-MainApplicationTest-fix-for-non-headless-mode.patch added |
---|
Hold back on this one anyway - having trouble on travis with it.