Modify ↓

Opened 3 years ago

Closed 8 months ago

#16391 closed enhancement (fixed)

[Patch] UI - Add noref=yes and noname=yes checkboxes next to ref and name fields

Reported by: LeTopographeFou Owned by: team
Priority: normal Milestone: 20.07
Component: Internal preset Version: latest
Keywords: noref noname name ref Cc:

Description

Whenever a ref or name field is displayed, add a checkbox next to it. If it is checked (no*=yes) then the text field is cleared and disabled. If unchecked, the text field is enable.

If not suitable for all features, then it can be used at least for motorway junctions.

Attachments (3)

josm_16391_19440.patch​ (14.8 KB) - added by skyper 8 months ago.
patch adding noname, noref and placement:forward/backward
josm_16391_19440_v2.patch​ (15.4 KB) - added by skyper 8 months ago.
version 2 including motorway_junction
josm_16391_19440_v3.patch​ (15.3 KB) - added by skyper 8 months ago.
version 3 without transition for forward/backward

Download all attachments as: .zip

Change History (15)

comment:1 Changed 3 years ago by LeTopographeFou

Summary: UI - Add noref=yes and noname=yes checkboxes next to réf and name fields → UI - Add noref=yes and noname=yes checkboxes next to ref and name fields

comment:2 Changed 2 years ago by simon04

Component: Core → Internal preset

comment:3 Changed 8 months ago by skyper

Interesting, any objections against adding two tags which are already used by validator.

comment:4 Changed 8 months ago by skyper

Mmh, I had a look at the highway presets. I do not like that placement:forward/backward is missing, see #19440. I could fix that within the scope of this ticket.

I am not sure if the growing length of the highway presets will be a problem.

Changed 8 months ago by skyper

Attachment: josm_16391_19440.patch​ added

patch adding noname, noref and placement:forward/backward

comment:5 Changed 8 months ago by skyper

Please, find attached patch josm_16391_19440.patch​ which:

  • adds noname and noref checkboxes
  • adds placement:forward/backward to all major highway presets (#19440)

I played a little bit with checkgroups for shorter presets and better look. I restrained adding many chunks and hope the patch has a correctly formed header, now.

comment:6 Changed 8 months ago by skyper

Summary: UI - Add noref=yes and noname=yes checkboxes next to ref and name fields → [Patch] UI - Add noref=yes and noname=yes checkboxes next to ref and name fields

Changed 8 months ago by skyper

Attachment: josm_16391_19440_v2.patch​ added

version 2 including motorway_junction

comment:7 Changed 8 months ago by skyper

Forgot to add noref and noname to motorway_junction which is included in version 2​.

Last edited 8 months ago by skyper (previous) (diff)

comment:8 Changed 8 months ago by skyper

Oh, I need to remove transition from placement:forward/backward values.

Last edited 8 months ago by skyper (previous) (diff)

comment:9 Changed 8 months ago by LeTopographeFou

Thanks Skyper for moving ahead on this feature but usually it is not a good idea to mix different topics in a same ticket. I recommand you to open another one for placement issue and keep this patch only for noref and noname checkboxes.

comment:10 Changed 8 months ago by skyper

I attached version 3​ with the correct values for placement:forward/backward.

Changed 8 months ago by skyper

Attachment: josm_16391_19440_v3.patch​ added

version 3 without transition for forward/backward

comment:11 Changed 8 months ago by Klumbumbus

Milestone: → 20.07

comment:12 Changed 8 months ago by Klumbumbus

Resolution: → fixed
Status: new → closed

In 16741/josm:

  • fix #19440 - Add placement:forward/backward to highway presets
  • fix #16391 - Add noref=yes and noname=yes checkboxes after ref and name fields in highway presets
  • save some space in height of preset window by reordering checks a bit
  • based on patch by skyper

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.