Opened 6 years ago

Closed 6 years ago

#16356 closed defect (fixed)

Fully automatic oauth window hides its own 'Authorize now' button

Reported by: anonymous Owned by: team
Priority: normal Milestone: 18.06
Component: Core Version:
Keywords: template_report oauth layout Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Go to Preferences -> Connection Settings.
  2. Click 'New Access Token', under Oauth. 'Fully Automatic' is the default, as it should be.
  3. You will bring up the 'Fully Automatic' window, which will illustrate the problem.

What is the expected result?

Attachment: nothidden.png

What happens instead?

Attachment: hidden.png

Please provide any additional information below. Attach a screenshot if possible.

Simply put, the default window size for the OAuth window hides the 'Authorize now' button. This is extremely confusing to someone who has never activated OAuth inside JOSM, because even when you put in a username and password, there doesn't appear to be a button to 'make the screen do something', unless you're clever enough to notice that there's a scroll inside that window. (see attachment, whatnext.png)

Again, it's really obvious once you know what you're looking for, but a first time user is going to be driven crazy by this. The solution is to make the window the proper size to show the Authorize Now button, which shouldn't be that difficult to do.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-06-04 00:50:29 +0200 (Mon, 04 Jun 2018)
Build-Date:2018-06-04 01:33:48

Identification: JOSM/1.5 (13887 en) Mac OS X 10.13.4
OS Build number: Mac OS X 10.13.4 (17E202)
Memory Usage: 452 MB / 2048 MB (254 MB allocated, but free)
Java version: 10.0.1+10, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69508142 2560x1440
Maximum Screen Size: 2560x1440
VM arguments: [--add-modules=ALL-DEFAULT,javafx.deploy,, -Djava.util.Arrays.useLegacyMergeSort=true, --add-modules=java.activation,, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.desktop/, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED,, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djnlpx.jvm=<java.home>/bin/java, -Djnlpx.home=<java.home>, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true,, -Djnlpx.heapsize=-1,2147483648,<java.home>/conf/security/javaws.policy, -DtrustProxy=true, -Djnlpx.origFilenameArg=Desktop/josm-latest.jnlp,, --illegal-access=deny, --add-modules=ALL-DEFAULT, --add-exports=java.base/, --add-exports=java.base/jdk.internal.misc=jdk.deploy, --add-exports=java.base/jdk.internal.util.jar=jdk.deploy, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/sun.nio=jdk.deploy, --add-exports=java.base/sun.reflect.misc=jdk.deploy, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/sun.usagetracker=jdk.deploy, --add-exports=java.desktop/sun.awt=jdk.deploy, --add-exports=java.naming/com.sun.jndi.toolkit.url=jdk.deploy, --add-exports=java.base/jdk.internal.misc=jdk.javaws, --add-exports=java.desktop/, --add-exports=java.desktop/sun.awt=jdk.javaws, --add-exports=java.desktop/sun.awt.image=jdk.javaws, --add-exports=java.base/jdk.internal.misc=jdk.plugin, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.desktop/, --add-exports=java.desktop/java.awt.peer=jdk.plugin, --add-exports=java.desktop/sun.applet=jdk.plugin, --add-exports=java.desktop/sun.applet.resources=jdk.plugin, --add-exports=java.desktop/sun.awt=jdk.plugin, --add-exports=java.desktop/, --add-exports=java.desktop/sun.swing=jdk.plugin, --add-exports=jdk.jsobject/jdk.internal.netscape.javascript.spi=jdk.plugin, --add-exports=java.desktop/, --add-exports=java.base/, --add-exports=java.base/, --add-exports=java.desktop/, --add-exports=java.desktop/, --add-exports=java.desktop/sun.lwawt.macosx=jdk.plugin, -Djdk.module.main=jdk.plugin]
Dataset consistency test: No problems found

+ SimplifyArea (34109)
+ pbf (34109)
+ wikipedia (v1.0.1)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Unknown element Calumet		0
- W: Region [WMS_BLOCK_v2] Resetting cache
- W: Region [WMTS_BLOCK_v2] Resetting cache

Attachments (3)

hidden.png (63.6 KB ) - added by anonymous 6 years ago.
nothidden.png (68.6 KB ) - added by anonymous 6 years ago.
whatnext.png (65.2 KB ) - added by anonymous 6 years ago.

Download all attachments as: .zip

Change History (5)

by anonymous, 6 years ago

Attachment: hidden.png added

by anonymous, 6 years ago

Attachment: nothidden.png added

by anonymous, 6 years ago

Attachment: whatnext.png added

comment:1 by Don-vip, 6 years ago

Description: modified (diff)
Keywords: oauth layout added
Milestone: 18.06

comment:2 by Don-vip, 6 years ago

Resolution: fixed
Status: newclosed

In 13892/josm:

fix #16356 - dynamic default size of OAuth wizard dialog

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.