Modify

Opened 5 months ago

Closed 5 months ago

#16357 closed enhancement (fixed)

Should use the imagery names in English in source

Reported by: naoliv Owned by: team
Priority: normal Milestone: 18.06
Component: Core imagery Version:
Keywords: upload changeset source i18n Cc:

Description

When we select "obtain from current layers" at the upload dialog, JOSM should always use the layer names in English (or probably the default name), instead using a local translation.

For example, in https://www.openstreetmap.org/changeset/59476722 I did use the "DigitalGlobe Standard Imagery" but it got inserted as "Imagem Comum da DigitalGlobe"

This should help to keep a standard for the source and also provide an easy identification of the sources (without needing to translate to identify what the person used)

JOSM:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-06-04 00:50:29 +0200 (Mon, 04 Jun 2018)
Revision:13887
Build-Date:2018-06-04 01:33:48
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (13887 pt_BR) Linux Debian GNU/Linux testing (buster)
Memory Usage: 1376 MB / 7168 MB (621 MB allocated, but free)
Java version: 10.0.1+10-Debian-4, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-10-jre:amd64-10.0.1+10-4
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-21
VM arguments: [--add-modules=java.activation,java.se.ee, -Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Attachments (0)

Change History (7)

comment:1 Changed 5 months ago by Klumbumbus

Maybe it would be better to use the id instead. It is a bit more cryptic but more stable. Not sure what id (the editor) uses atm.

comment:2 Changed 5 months ago by naoliv

iD seems to be using the default names (in English, usually)
For example https://www.openstreetmap.org/changeset/59534917

comment:3 Changed 5 months ago by Don-vip

Component: CoreCore imagery
Keywords: upload changeset source i18n added

comment:4 Changed 5 months ago by Don-vip

We can use both. For example there are a large number of source:ja and source:en in the database, so we could set source to English name, and keep the current localized name in source:pt_BR, etc.

comment:5 Changed 5 months ago by Don-vip

Milestone: 18.06

Mmm not so easy, I'll stick to English name.

comment:6 Changed 5 months ago by anonymous

Id (ELI) has opt in for i18n only for some global layers. So alot of names are in the local language.

comment:7 Changed 5 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13890/josm:

fix #16357 - use English imagery names in changeset source tag

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.