Modify

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#16355 closed defect (fixed)

Ignored validation findings reappear on upload [patch]

Reported by: bhatchl Owned by: team
Priority: minor Milestone: 18.06
Component: Core validator Version: tested
Keywords: upload hook Cc:

Description

After ignoring an single validation finding in the Validator dialog, and attempting an upload, the Upload dialog correctly displays only un-ignored validation findings, but the Validator dialog is refreshed with all validation findings, causing the single ignored finding to reappear.

I've attached a screenshot that shows two findings in the Upload dialog, but three in the Validator dialog.

I've also attached a patch to ValidateUploadHook.java that simple moves the block of code updating the Edit Layer and Validator dialog "errors" to after the ignored settings are processed.

Attachments (2)

ignored_error_reappearing.png (79.2 KB) - added by bhatchl 6 months ago.
screen shot of ignored validation finding reappearing
ignored_validation_reappearing.patch (2.0 KB) - added by bhatchl 6 months ago.
patch file fixing ignored validation finding reappearing

Download all attachments as: .zip

Change History (6)

Changed 6 months ago by bhatchl

screen shot of ignored validation finding reappearing

Changed 6 months ago by bhatchl

patch file fixing ignored validation finding reappearing

comment:1 Changed 6 months ago by Klumbumbus

Component: CoreCore validator
Summary: Ignored validation findings reappear on uploadIgnored validation findings reappear on upload [patch]

comment:2 Changed 6 months ago by Don-vip

Keywords: upload hook added
Milestone: 18.06

comment:3 Changed 6 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13893/josm:

fix #16355 - Ignored validation findings reappear on upload (patch by bhatchl)

comment:4 Changed 6 months ago by Don-vip

Thanks for the patch! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.