IAE: Listener ImageryAdjustAction... when pressing a key during image offset adjust

[IlBano]

What steps will reproduce the problem?

1. load some data from OSM
2. activate an imagery of choice
3. select from imagery menu "New offset"
4. left clic pressed on the imagery to change the offset
5. press some key like A, S,or X (probably others involved too)

What is the expected result?

Nothing should happen by pressing a key while focus is on imagery

What happens instead?

JOSM crashes with an exception as reported below

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-03-04 16:20:37 +0100 (Sun, 04 Mar 2018)
Build-Date:2018-03-04 15:24:13
Revision:13500
Redirecting:to URL 'https://josm.openstreetmap.de/svn/trunk':
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13500 en) Windows 7 32-Bit
OS Build number: Windows 7 Ultimate (7601)
Memory Usage: 676 MB / 676 MB (267 MB allocated, but free)
Java version: 1.8.0_151-b12, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1280x1024
Maximum Screen Size: 1280x1024
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-117bc37a, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=51451, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ SimplifyArea (33918)
+ apache-commons (33668)
+ buildings_tools (34040)
+ ejml (32680)
+ ext_tools (33889)
+ geotools (33958)
+ imagery_offset_db (33774)
+ jogl (1.1.0)
+ jts (32699)
+ log4j (32699)
+ opendata (34072)
+ poly (33570)
+ utilsplugin2 (33991)

Tagging presets:
+ D:\Josm\cai.xml
+ D:\Josm\presets\myJosmPresets.xml

Map paint styles:
- D:\Josm\bano.mapcss

Last errors/warnings:
- E: Failed to locate image 'presets/diy_store.png'
- W:  null: Could not get presets icon presets/diy_store.png
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.actions.ImageryAdjustAction@434118 (instance of org.openstreetmap.josm.actions.ImageryAdjustAction) was not registered before or already removed.
- E: Handled by bug report queue: java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.actions.ImageryAdjustAction@434118 (instance of org.openstreetmap.josm.actions.ImageryAdjustAction) was not registered before or already removed.


=== STACK TRACE ===
Thread: AWT-EventQueue-2 (57) of javawsApplicationThreadGroup
java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.actions.ImageryAdjustAction@434118 (instance of org.openstreetmap.josm.actions.ImageryAdjustAction) was not registered before or already removed.
	at org.openstreetmap.josm.tools.ListenerList.failRemove(ListenerList.java:132)
	at org.openstreetmap.josm.tools.ListenerList.removeListener(ListenerList.java:126)
	at org.openstreetmap.josm.data.Preferences.removePreferenceChangeListener(Preferences.java:182)
	at org.openstreetmap.josm.actions.mapmode.MapMode.exitMode(MapMode.java:83)
	at org.openstreetmap.josm.actions.ImageryAdjustAction.exitMode(ImageryAdjustAction.java:116)
	at org.openstreetmap.josm.gui.MapFrame.selectMapMode(MapFrame.java:480)
	at org.openstreetmap.josm.gui.MapFrame.selectMapMode(MapFrame.java:462)
	at org.openstreetmap.josm.actions.mapmode.MapMode.actionPerformed(MapMode.java:111)
	at javax.swing.SwingUtilities.notifyAction(Unknown Source)
	at javax.swing.JComponent.processKeyBinding(Unknown Source)
	at javax.swing.KeyboardManager.fireBinding(Unknown Source)
	at javax.swing.KeyboardManager.fireKeyboardAction(Unknown Source)
	at javax.swing.JComponent.processKeyBindingsForAllComponents(Unknown Source)
	at javax.swing.JComponent.processKeyBindings(Unknown Source)
	at javax.swing.JComponent.processKeyEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[Don-vip]

#15849 not fully fixed... :(

[Don-vip]

In 13546/josm:

fix #16053, see #15849 - make ImageryAdjustAction robust to change of map mode via shortcut

[Don-vip]

@IlBano: can you please check everything's OK with offset mode?

[IlBano]

Replying to Don-vip:

@IlBano: can you please check everything's OK with offset mode?

Tested with 13549. No more exception after pressing a key, but:

1. offset dialog is closed without warnings
2. selected offset is not saved
3. the action associated with the key is executed (e.g. 'A' switches JOSM to "Draw nodes")

[Don-vip]

Replying to IlBano:

2. selected offset is not saved

Ah, I missed this point, see #16133 :( I can't get this feature to work properly ><

[Don-vip]

In 13686/josm:

fix #16133, see #16053 - fix imagery layer offset bug (regression of r13546)

[Don-vip]

In 13694/josm:

fix #16133, see #16053 - fix imagery layer offset bug (regression of r13546)