Modify

Opened 3 years ago

Closed 3 years ago

#15965 closed defect (fixed)

changes to Swiss Imagery entries

Reported by: Klumbumbus Owned by: marc_marc
Priority: normal Milestone:
Component: External imagery source Version:
Keywords: Cc:

Description

Hello and thanks a lot for helping updating imagery entries.

I have a few remarks:

  • Please don't change existing ids. They must not be changed to ensure the automatic update mechanism in JOSM works fine.
  • Names and descriptions are part of the translated strings, therefore please use english. (We know that there are currently a lot (old) non english imagery names in our database. We don't changed them to reduce the load for translators. But for new entries or when changes are really required then please only english.)
  • The solothurn URLs in our database is the one with the latest imageries. Every year 1/3 of the imageries of solothurn is renewed and therfore the complete solothurn area is from the last 3 years. See the descriptions at https://www.so.ch/?id=2354

Therefore I reverted some of your changes.

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by marc_marc

Hello,

  • for id, I try to reduce diff between eli and josm and I tried to pick the most consistent id of the two.
  • for name/description, you are right, I should keep english version on josm and fix name/description on eli.
  • Solothum : I'll check again what's I make wrong.

Thanks for the message.

comment:2 in reply to:  1 ; Changed 3 years ago by Klumbumbus

Replying to marc_marc:

  • for id, I try to reduce diff between eli and josm and I tried to pick the most consistent id of the two.

differences in id are not a problem at the moment as the comparison script is based on the URL. ids in the JOSM database should not be changed until a solution is found which keeps the entries in the users defined lists (see also ticket:14655#comment:60 and following for deeper background).

If you want to reduce the diff between JOSM and ELI (which would be much appreciated) you may start with the yellow entries at ImageryCompare. Very minor changes which result in "disadvantages" for JOSM (like retranslations of names) should be avoided. Usually these differences are marked green.

  • for name/description, you are right, I should keep english version on josm and fix name/description on eli.

ELI has an opt-in for translations, so a sync may not be possible in all cases.

  • Solothum : I'll check again what's I make wrong.

I updated the dates in my last change too, so it should be fine now.

comment:3 in reply to:  2 Changed 3 years ago by marc_marc

Replying to Klumbumbus:

Replying to marc_marc:

  • for id, I try to reduce diff between eli and josm and I tried to pick the most consistent id of the two.

differences in id are not a problem at the moment as the comparison script is based on the URL. ids in the JOSM database should not be changed until a solution is found which keeps the entries in the users defined lists (see also ticket:14655#comment:60 and following for deeper background).

I 'll read it.

If you want to reduce the diff between JOSM and ELI (which would be much appreciated) you may start with the yellow entries at ImageryCompare.

I'll start by adding missing layers (at eli side), then fix missing and shape diff.

  • for name/description, you are right, I should keep english version on josm and fix name/description on eli.

ELI has an opt-in for translations, so a sync may not be possible in all cases.

I'll check this with eli (adding both english + translated name).

  • Solothum : I'll check again what's I make wrong.

I updated the dates in my last change too, so it should be fine now.

Thank you for taking the time to explain our revert : -)

comment:4 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain marc_marc.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.