Modify

Opened 3 months ago

Last modified 2 months ago

#15943 reopened defect

Misbehaviour or wrong description of search string 'key='

Reported by: selfishseahorse@… Owned by: team
Priority: normal Milestone: 18.02
Component: Core Version: tested
Keywords: template_report Cc:

Description (last modified by Klumbumbus)

In the search (or filter) window, the search string 'key=' is explained (in the tooltip) to "match if 'key' exists", however it does the opposite: it matches if 'key' is empty.

What steps will reproduce the problem?

  1. Ctrl + F
  2. Enter type:way highway=* -surface=

What is the expected result?

Select highways without surface tag

What happens instead?

Highways *with* existing surface tag are highlighted.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-01-28 23:08:56 +0100 (Sun, 28 Jan 2018)
Build-Date:2018-01-28 22:25:44
Revision:13367
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13367 en_GB) Mac OS X 10.12.6
OS Build number: Mac OS X 10.12.6 (16G1212)
Memory Usage: 384 MB / 910 MB (96 MB allocated, but free)
Java version: 1.8.0_161-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69677504 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.library.path=/Applications/JOSM.app/Contents/MacOS, -DLibraryDirectory=${HOME}/Library, -DDocumentsDirectory=${HOME}/Documents, -DApplicationSupportDirectory=${HOME}/Library/Application Support, -DCachesDirectory=${HOME}/Library/Caches, -DSandboxEnabled=false, -Dapple.laf.useScreenMenuBar=true, -Dcom.apple.macos.use-file-dialog-packages=true, -Dcom.apple.macos.useScreenMenuBar=true, -Dcom.apple.mrj.application.apple.menu.about.name=JOSM, -Dcom.apple.smallTabs=true]
Dataset consistency test: No problems found

Plugins:
+ reverter (34036)
+ tageditor (33806)
+ undelete (33980)
+ utilsplugin2 (33991)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=400, Error Header=<You requested too many nodes (limit is 50000). Either request a smaller area, or use planet.osm>
- E: Bad Request - <html>The OSM server 'api.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.</html>

Attachments (0)

Change History (6)

comment:1 Changed 3 months ago by Klumbumbus

Milestone: 18.02

I would rather say that key= is wrong, it should be key. Then it matches with the tooltip and its behavior.

I'm not sure if it is even possible in the osm database to have emtpy values.

comment:2 Changed 3 months ago by Klumbumbus

Description: modified (diff)

comment:3 Changed 3 months ago by selfishseahorse@…

I'm not sure if it is even possible in the osm database to have emtpy values.

Yes, it is:

https://www.openstreetmap.org/way/292168826

(Added with level0.)

comment:4 Changed 3 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13430/josm:

fix #15943 - allow to search empty values

comment:5 Changed 3 months ago by Klumbumbus

In 13432/josm:

see #15943 - adjust search hints. reorder, fix key= to key and add the new key=

comment:6 Changed 2 months ago by selfishseahorse@…

Resolution: fixed
Status: closedreopened

It seems that there's still something wrong with the filter:

  • type:way highway sidewalk= filters highway ways with any sidewalk value, not just those with an empty sidewalk value
  • type:way highway -sidewalk also filters footway=sidewalk, but in footway=sidewalk, sidewalk is the value, not the key

JOSM version used: 13500

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to selfishseahorse@gmail.com
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.