Modify

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#15036 closed enhancement (fixed)

[PATCH] Add provinces of China and India to data/boundaries.xml

Reported by: westnordost Owned by: team
Priority: normal Milestone: 17.07
Component: Core Version:
Keywords: boundaries, geocoding Cc:

Description

I added the provinces of India and China to the boundaries.xml

It increases the file size by 0.39MB to 1.88MB.

Rationale:
India and China are very big countries that unify many different people and more importantly many different languages. The more detailed data could be used to make better multilingual name suggestions. (I.e. official language in Gujarat is Gurarati, in Kerala Malayalam, in Tibet Tibetan along with Chinese etc.)

See this file

Patch
I was unable (again) to create a proper patch, Winmerge generates a patch which deletes everything and adds all of my changes. In KDiff however, the diff looks good (but KDiff can't export a patch). So, I attach the whole file and you can diff it with the tool of your choice with the master version.

Attachments (2)

boundaries.osm (1.9 MB ) - added by westnordost 8 years ago.
boundaries.osm.patch (379.2 KB ) - added by Don-vip 8 years ago.

Change History (7)

by westnordost, 8 years ago

Attachment: boundaries.osm added

comment:1 by westnordost, 8 years ago

Eh, I mean trunk version. :-)

by Don-vip, 8 years ago

Attachment: boundaries.osm.patch added

comment:2 by Don-vip, 8 years ago

Milestone: 17.07

Great, SVN is able to make proper patches now :)

comment:3 by Don-vip, 8 years ago

Resolution: fixed
Status: newclosed

In 12484/josm:

fix #15036 - Add provinces of China and India to data/boundaries.xml (patch by westnordost)

comment:4 by Don-vip, 7 years ago

ISO has changed China's codes:

Effective date of change: 2017-11-23

Short description of change (en):

Change of subdivision code from CN-15 to CN-NM, CN-45 to CN-GX, CN-54 to CN-XZ, CN-64 to CN-NX, CN-65 to CN-XJ, CN-11 to CN-BJ, CN-12 to CN-TJ, CN-31 to CN-SH, CN-50 to CN-CQ, CN-13 to CN-HE, CN-14 to CN-SX, CN-21 to CN-LN, CN-22 to CN-JL, CN-23 to CN-HL, CN-32 to CN-JS, CN-33 to CN-ZJ, CN-34 to CN-AH, CN-35 to CN-FJ, CN-36 to CN-JX, CN-37 to CN-SD, CN-41 to CN-HA, CN-42 to CN-HB, CN-43 to CN-HN, CN-44 to CN-GD, CN-46 to CN-HI, CN-51 to CN-SC, CN-52 to CN-GZ, CN-53 to CN-YN, CN-61 to CN-SN, CN-62 to CN-GS, CN-63 to CN-QH, CN-71 to CN-TW, CN-91 to CN-HK, CN-92 to CN-MO; change of subdivision name of CN-NM, CN-GX, CN-XZ, CN-NX, CN-XJ, CN-BJ, CN-TJ, CN-SH, CN-CQ, CN-HE, CN-SX, CN-LN, CN-JL, CN-HL CN-JS, CN-ZJ, CN-AH, CN-FJ, CN-JX, CN-SD, CN-HA, CN-HB, CN-HN, CN-GD, CN-HI, CN-SC, CN-GZ, CN-YN, CN-SN, CN-GS, CN-QH, CN-TW, CN-HK, CN-MO; addition of remark in parentheses to subdivision name for CN-HK, CN-MO in eng; addition of region CN-MO in por; update Code Source; update List Source

comment:5 by Don-vip, 7 years ago

In 13412/josm:

see #15036, see #15870 - update China ISO3166-2 province codes (2017-11-23 update) + unit test

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.