Modify

Opened 7 years ago

Last modified 3 years ago

#14711 new defect

when sorting members of a route, look at oneway tag of ways or direction of roundabout

Reported by: Polyglot Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: Relation Editor, relation-sorting, public-transport-v2, sort, route, roundabout Cc: ToniE

Description

When sorting members of a bus route (public_transport:version=2), it would be nice to not go against the flow of oneway traffic or go around roundabouts the wrong way. This applies to roundabouts with split ways.

It would help a lot if oneway=yes (and its exceptions oneway:bus=no/oneway:psv=no) would be taken into account.

The same goes for bicycle routes (of course there the exceptions would be oneway:bicycle=no)

Attachments (0)

Change History (9)

comment:1 by ToniE, 7 years ago

Cc: ToniE added

comment:2 by ToniE, 7 years ago

Type: enhancementdefect
Version: tested

I see this as a defect rather than an enhancement.

Analysis of existing bus routes in Munich area (MVV) show many such errors (https://wiki.openstreetmap.org/wiki/M%C3%BCnchen/Transportation/Analyse#Landkreis_Ebersberg_-_400_-_499)
Most of them caused by users mapping 2 separate highways with oneway=yes where there was a single highway before - at junctions with islands for instance.
They then forget to adapt the bus routes.

comment:3 by Polyglot, 7 years ago

the enhancement part would be to follow oneway flow and try to get off the roundabout as soon as that is possible, when sorting.

Also give preference to a way that doesn't have a oneway tag over one that does (the one with the oneway tag, is probably the 'other leg' of a fork that leads back to the roundabout (or where a dual-carriageway split), rather than the continuation of the route itinerary).

Since sorting shouldn't change the amount of members in the route relations, all the 'unnecessary' members will end up at the end, where the user can either simply remove them easily, or from where he can zoom to them one by one to check whether sorting happened correctly.

I should really add some test cases to this ticket...

Jo

comment:4 by Polyglot, 5 years ago

PT_Assistant does a decent job now to create routes heeding oneway traffic and turn restrictions, sorting a route relation doesn't yet though, so I'll keep this ticket open for the time being.

On split roundabouts it would be needed to detect if it's used more than once (to go into a loop). If there is a loop, the exit to it should be used first.

When coming off a roundabout on a fork of 2 oneways, select the way that doesn't double back to the roundabout, but that leads away from it (most likely not a oneway).

comment:5 by simon04, 5 years ago

Keywords: relation-sorting public-transport-v2 added

comment:6 by skyper, 4 years ago

Keywords: sort route added

comment:7 by skyper, 4 years ago

Keywords: roundabout added

in reply to:  3 comment:8 by skyper, 4 years ago

See #6920.

Replying to Polyglot:


I should really add some test cases to this ticket...

Yes, please.

comment:9 by skyper, 3 years ago

#6920 is about roundabouts in general and #17899 about oneway with bicycle routes, only.
How should a general rule for oneway look like? Talking only the value of route=* as access (sub-)key will not work in many cases.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to Polyglot.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.