Modify

Opened 8 years ago

Last modified 3 months ago

#6920 new defect

sorting error relations of participants

Reported by: ErshKUS Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: sort, relation, public-transport-v1, relation-sorting Cc:

Description (last modified by Larry0ua)

sorting error relations of participants.
http://www.openstreetmap.org/browse/relation/32929

example attached

Attachments (1)

relations_sort.osm (12.0 KB) - added by Larry0ua 7 years ago.
updated version which is more valid I hope

Download all attachments as: .zip

Change History (15)

comment:1 Changed 8 years ago by stoecker

Owner: changed from team to ErshKUS
Status: newneedinfo

Please be more verbose about what you want. Currently your report isn't understandable.

comment:2 Changed 8 years ago by ErshKUS

Status: needinfonew

Open this relation (in "editor relations"), press "sort" in participants and incorrectly sorted participants.

comment:3 Changed 8 years ago by simon04

We had another ticket which stated that Sort the relation members does not work as expected, i.e., producing an unsorted list. Repeated executions of this sorting change the order every time (the result is not stable). Unfortunately, I couldn't find that other ticket now.

comment:4 Changed 8 years ago by skyper

Did you mean #6732.
I noticed JOSM not working correctly with loops but have to look for an example.

It is always much easier with an example as .osm file as objects are changing on the OSM server.

comment:5 in reply to:  4 Changed 8 years ago by simon04

Replying to skyper:

Did you mean #6732.

I think so, yes.

It is always much easier with an example as .osm file as objects are changing on the OSM server.

I agree. Therefore, I created #6804.

Last edited 8 years ago by simon04 (previous) (diff)

comment:6 Changed 7 years ago by Larry0ua

Description: modified (diff)

Example attached - top 2 routes are not sorted correctly, and 3 last - sorted.

Changed 7 years ago by Larry0ua

Attachment: relations_sort.osm added

updated version which is more valid I hope

comment:7 Changed 7 years ago by Larry0ua

I checked file once again - now there are relations that can be sorted with some sequence of members, but are broken after pressing "sort" button.

However I do not know if previous version should be sorted or not - that was like current but without connected ends of left and right side (was =o=, not -==o==- )

comment:8 Changed 7 years ago by Larry0ua

Description: modified (diff)
Owner: changed from ErshKUS to skyper

comment:9 Changed 7 years ago by skyper

Owner: changed from skyper to team

comment:10 in reply to:  7 Changed 7 years ago by skyper

Replying to Larry0ua:

I checked file once again - now there are relations that can be sorted with some sequence of members, but are broken after pressing "sort" button.

However I do not know if previous version should be sorted or not - that was like current but without connected ends of left and right side (was =o=, not -==o==- )

I tend to split up the roundabout in 1) and 2), if the route does not follow all segments of the roundabout.

I also always add role:forward to roundabouts.

comment:11 Changed 7 years ago by Larry0ua

Yes, when I split roundabout it works OK, but current sorting code tends to work with such cases, isn't it?

By the way, adding role forward to roundabout does not make any sense to that sorting code - it checks if line is roundabout, and if not - if that is oneway forward/backward or not (RelationNodeMap.java:86-100)

comment:12 in reply to:  11 Changed 7 years ago by skyper

Replying to Larry0ua:

Yes, when I split roundabout it works OK, but current sorting code tends to work with such cases, isn't it?

Have not much time right now !
It should as there might be cases where the whole roundabount is part of the route.

There was a case with routes taking a loop and then continuing which did not work if part of the loop is used in both directions (A):

A:  |                        B:  |
    ^                            ^
    |    _                       | ___
    |___| |                      |/   \
    |   |_|                      |\___/
    |                            |
    ^                            ^
    |                            |

but I also did not check if it works if the loop consists of ways only used in on direction (B).

By the way, adding role forward to roundabout does not make any sense to that sorting code - it checks if line is roundabout, and if not - if that is oneway forward/backward or not (RelationNodeMap.java:86-100)

Was only a generell suggestion. Maybe some other code will use it.

comment:13 Changed 7 years ago by skyper

Ticket #6983 has been marked as a duplicate of this ticket.

comment:14 Changed 3 months ago by simon04

Keywords: public-transport-v1 relation-sorting added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to ErshKUS
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.