#14395 closed enhancement (fixed)
Add building attached to road as a validation warning
Reported by: | awiseman | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 17.03 |
Component: | Core validator | Version: | |
Keywords: | Cc: |
Description
I've often seen buildings (or other features) attached to roads, I believe because of snapping in iD and JOSM. Can we add that as a validation warning? I think in the vast majority of cases it will be incorrect, except for places where roads go through or under buildings.
Attachments (2)
Change History (10)
comment:1 by , 8 years ago
Component: | Core → Core validator |
---|
comment:4 by , 8 years ago
Keywords: | validation removed |
---|---|
Milestone: | → 17.03 |
I hope this doesn't produce false positives.
follow-up: 7 comment:5 by , 8 years ago
I do this in a more generic way in my local rules:
way[highway] > node { set .is_in_highway; } area[!highway] > node.is_in_highway { throwWarning: tr("area connected to highway"); }
ie, it doesn't matter the type of area (landuse
, leisure
, building
, etc)
comment:6 by , 8 years ago
With the attached example1 you should see the problem: it detects 3 connected nodes (instead the way/area).
With example2 there is one problem in testing for first_last_node
: it doesn't detect when the first/last node is connected to the highway.
If detecting all connected nodes is acceptable, maybe the test for first_last_node
should be removed?
by , 8 years ago
Attachment: | example1.osm added |
---|
by , 8 years ago
Attachment: | example2.osm added |
---|
comment:7 by , 8 years ago
Replying to naoliv:
way[highway] > node { set .is_in_highway; } area[!highway] > node.is_in_highway { throwWarning: tr("area connected to highway"); }
This code produces false positives for
- building passages, fuel station, car wash,... (e.g. #map=19/50.71033/12.86643)
- highways mapped as area (e.g. way/209763090)
Both cases are very common.
changing to validator