Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14395 closed enhancement (fixed)

Add building attached to road as a validation warning

Reported by: awiseman Owned by: team
Priority: normal Milestone: 17.03
Component: Core validator Version:
Keywords: Cc:

Description

I've often seen buildings (or other features) attached to roads, I believe because of snapping in iD and JOSM. Can we add that as a validation warning? I think in the vast majority of cases it will be incorrect, except for places where roads go through or under buildings.

Attachments (2)

example1.osm (2.2 KB ) - added by naoliv 7 years ago.
example2.osm (2.5 KB ) - added by naoliv 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by anonymous, 7 years ago

Component: CoreCore validator

changing to validator

comment:2 by anonymous, 7 years ago

anybody?

comment:3 by Klumbumbus, 7 years ago

Resolution: fixed
Status: newclosed

In 11736/josm:

fix #14395 - Add building attached to road as a validation warning

comment:4 by Klumbumbus, 7 years ago

Keywords: validation removed
Milestone: 17.03

I hope this doesn't produce false positives.

comment:5 by naoliv, 7 years ago

I do this in a more generic way in my local rules:

way[highway] > node { set .is_in_highway; }

area[!highway] > node.is_in_highway {
        throwWarning: tr("area connected to highway");
}

ie, it doesn't matter the type of area (landuse, leisure, building, etc)

But for a proper solution it needs #11523/#10215

comment:6 by naoliv, 7 years ago

With the attached example1 you should see the problem: it detects 3 connected nodes (instead the way/area).
With example2 there is one problem in testing for first_last_node: it doesn't detect when the first/last node is connected to the highway.

If detecting all connected nodes is acceptable, maybe the test for first_last_node should be removed?

by naoliv, 7 years ago

Attachment: example1.osm added

by naoliv, 7 years ago

Attachment: example2.osm added

in reply to:  5 comment:7 by Klumbumbus, 7 years ago

Replying to naoliv:

way[highway] > node { set .is_in_highway; }

area[!highway] > node.is_in_highway {
        throwWarning: tr("area connected to highway");
}

This code produces false positives for

Both cases are very common.

comment:8 by Klumbumbus, 7 years ago

In 12089/josm:

see #14395 - avoid false positive connection warning with building=no

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.