Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#14393 closed defect (fixed)

"Sport without physical feature" validation. leisure= bowling_alley is not accepted as physical feature.

Reported by: brian.tuffy@… Owned by: team
Priority: normal Milestone: 17.02
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Area or node tagged with leisure= bowling_alley and sport = ##
  2. run validation

What is the expected result?

Expect = leisure = bowling_alley is accepted as physical feature.

What happens instead?

validation warning "missing tag - sport without physical feature"

Please provide any additional information below. Attach a screenshot if possible.

leisure= pitch, swimming_pool etc. are accepted as physical features, bowling_alley is not.
I can resolve the warning by adding building = yes BUT two sports can occur in the same building.

Example: node 1 is sport=10pin, leisure=bowling_alley and node 2 is sport=billiards, leisure=bowling_alley inside an area with building = yes. This gives a validation warning. If leisure = sports_centre, no warning is given as expected.

According to OSM Wiki on sport=billiards:
"Since this is a non-physical tag it should always be combined with some other (physical) tags, eg:* leisure=pitch
amenity=pub
leisure=bowling_alley"

leisure=bowling_alley is not in the OSM list of physical features,... yet! I will attempt to add it.
https://wiki.openstreetmap.org/wiki/Key:sport

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2017-02-02 01:22:52 +0100 (Thu, 02 Feb 2017)
Build-Date:2017-02-02 02:33:28
Revision:11526
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11526 en) Windows 10 64-Bit
Memory Usage: 1376 MB / 1792 MB (659 MB allocated, but free)
Java version: 1.8.0_111-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1360x768
Maximum Screen Size: 1360x768
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-111ba38e, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=50739, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (33005)
+ HouseNumberTaggingTool (32699)
+ ImproveOsm (93)
+ Mapillary (v1.3.2)
+ apache-commons (32994)
+ apache-http (32699)
+ buildings_tools (33004)
+ graphview (33004)
+ scoutsigns (92)
+ terracer (33088)
+ utilsplugin2 (33124)
+ walkingpapers (32796)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/CampingForOverlanders&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Addr2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Crafts&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Simple_Indoor_Tagging&zip=1
+ https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ http://somewhere.dk/email/josm/source.xml
+ http://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Irishboundaries&zip=1

Map paint styles:
- http://maps.openstreetmap.ie/josm/townland.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT1_MapCSS.mapcss
- https://github.com/gmgeo/osmic-josm-style/archive/master.zip
- https://raw.githubusercontent.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.mapcss
- %UserProfile%\Documents\OSM Research\JOSM Sessions\JOSM Paint Styles\townland.mapcss

Last errors/warnings:
- W: Crossing ways test (MP) skipped WaySegment [way=414032552, lowerIndex=115]
- W: Crossing ways test (MP) skipped WaySegment [way=414032552, lowerIndex=116]
- W: Crossing ways test (MP) skipped WaySegment [way=414032552, lowerIndex=117]
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'
- W: Conflict in data - <html>This relation has been changed outside of the editor.<br>You cannot apply your changes and continue editing.<br><br>Do you want to create a conflict and close the editor?</html>

Attachments (0)

Change History (3)

comment:1 Changed 2 years ago by anonymous

forgot to add that in this case, leisure = sports_centre conflicts with leisure=bowling_alley, so I cannot have both of them or i will get a "leisure inside leisure" warning.

comment:2 Changed 2 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 11591/josm:

fix #14393 - allow leisure=bowling_alley as physical feature for sport tags

comment:3 Changed 2 years ago by Klumbumbus

Milestone: 17.02

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.