validator: appointment syntax in opening_hours

[dieterdreist]

The validator gives this warning:
(Please use notation ""on appointment"" for "by_appointment", but quotation marks aren't documented in the wiki, neither is "on appointment". The only example for appointments is "by appointment": ​https://wiki.openstreetmap.org/wiki/Key:opening_hours

Interestingly there seems to be another inconsistency, because after I added quotation marks the warning disappeared (i.e. by appointment rather than on appointment was accepted).

There is not much usage of these values anyway, but the "by appointment" has clearly more than the "on appointment": ​https://taginfo.openstreetmap.org/search?q=appointment#values

There is also a longer discussion here:
​https://wiki.openstreetmap.org/wiki/Talk:Key:opening_hours

I find it strange to use quotation marks in a formalized value, we do this nowhere else, and JOSM shouldn't recommend it. Why not by_appointment?

[stoecker]

Probably should be reported here: ​https://github.com/opening-hours/opening_hours.js

[Don-vip]

The opening_hours validation is completely delegated to ​https://github.com/opening-hours/opening_hours.js project, please create an issue there for this subject.

[Klumbumbus]

created: ​https://github.com/opening-hours/opening_hours.js/issues/210