Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#14181 closed enhancement (fixed)

[PATCH] GeoImageLayer: Improvements of display of selected photo in map

Reported by: holgermappt Owned by: team
Priority: normal Milestone: 17.01
Component: Core image mapping Version: latest
Keywords: Cc:


The patch includes three improvements of the way the selected photo is displayed on the map:

  1. The thumbnail of the selected photo is now drawn on top of all other thumbnails of the current layer. I.e. the selected photo is always shown in case multiple thumbnails overlap. Before the last photo in the image list was on top.
    • New:
      • paintImage()
      • showCurrentPhoto() (updateOffscreenBuffer = true)
    • Changed:
      • paint()
      • showNextPhoto()
      • showPreviousPhoto()
      • showFirstPhoto()
      • showLastPhoto()
      • mouseAdapter.mouseReleased()
  2. Clear the selection in other layers for all operations that select a photo (first/next/previous/last/click). Before only a selection in the map would clear other layers.
    • New:
      • showCurrentPhoto() (clearOtherCurrentPhotos())
    • Changed:
      • showNextPhoto()
      • showPreviousPhoto()
      • showFirstPhoto()
      • showLastPhoto()
      • removeCurrentPhoto()
      • removeCurrentPhotoFromDisk()
  3. Cycle through photos if multiple photo icons or thumbnails are below the mouse, mouse button1 is clicked, the mouse is not moved, and the map mode is supported (select, lasso, or other map mode registered for geo image layer).
    • New:
      • mouseMotionAdapter/MouseMotionAdapter
      • lastSelPos
      • cycleModeArmed
      • isPhotoIdxUnderMouse()
      • getPhotoIdxUnderMouse()
    • Changed:
      • mouseAdapter.mousePressed()
      • mouseAdapter.mouseReleased()
      • getPhotoUnderMouse()

Attachments (1)

GeoImageLayer_select.patch (16.4 KB) - added by holgermappt 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by holgermappt

Attachment: GeoImageLayer_select.patch added

comment:1 Changed 5 years ago by Don-vip

Milestone: 17.01

comment:2 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 11434/josm:

fix #14181 - GeoImageLayer: Improvements of display of selected photo in map (patch by holgermappt)

comment:3 Changed 5 years ago by Don-vip


Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.