Add tag2link plugin to core

[openstreetmap.org-user-d1g]

There no better alternatives to what it does, right? If there no alternatives, simply include it in core?

Additionally it doesn't clutter main interface with menus and buttons, but provides context items.

[simon04]

In 15673/josm:

see #13901 - Reimplement Tag2Link in core

The plugin tag2link has been created and maintained by Don-vip.

[simon04]

Originally I planned to rewrite the functionality to a MapCSS based syntax. However, everything got so complex that I gave up. attachment:mapcss-tag2link.patch​​

To keep it simple, I implemented the rules as a plain Java function.

In r15673, I migrated the first half of the ruleset. The country specific rules (FR, NL, CZ) are outstanding.

[Don-vip]

I don't like the idea of maintaining these rules in Java code... Did you start to code #18542? It's a much better way for the OSM community (i.e: not us) to maintain the rules.

[simon04]

In 15677/josm:

fix #18542, see #13901 - Obtain tag2link rules from Wikidata

[simon04]

In 15679/josm:

see #13901 see #18542 - Obtain tag2link rules from OSM Sophox

[simon04]

In 15686/josm:

see #13901 - deprecate tag2link plugin

[simon04]

In 15687/josm:

see #13901 - Tag2Link: add popup menu separator

[Don-vip]

Why didn't you use addSeparator()?

[Klumbumbus]

I noticed a problem (related to #14465): If you not all selected objects have key then you get additional links leading to nowhere other than the naked link, e.g. ​https://twitter.com/

[simon04]

Replying to Don-vip:

Why didn't you use addSeparator()?

Because I cannot remove that one in popupMenuWillBecomeInvisible (since addSeparator "returns" void).

[stoecker]

I don't like much that this change causes permanent web accesses to non-JOSM servers for elements which are not users-selected. We're giving a telemetry of user actions this way to providers we haven't under control.

[Don-vip]

I'm not sure the new Tag2Link class fits in the gui/util package, there is nothing related to Swing here. It would probably fit better in tools package. There are also a few SonarQube issues introduced: https://josm.openstreetmap.de/sonar/project/issues?id=josm&open=AW-Ruc2pdKVGF04AqhG2&resolved=false&sinceLeakPeriod=true&types=BUG

The search engine should also be configurable, we can't force JOSM users to use DuckDuckGo. It can be the default but we should also propose Qwant, Bing and Google.

[simon04]

In 15701/josm:

see #13901 - fix SonarQube issues

[simon04]

In 15702/josm:

see #13901 - move Tag2Link to tools/

[simon04]

Replying to Klumbumbus:

If you not all selected objects have key then you get additional links leading to nowhere other than the naked link, e.g. ​https://twitter.com/

Please check the tooltip – the links have different URLs, but their names/labels are indistinguishable. Let's continue in #14465.

Replying to stoecker:

I don't like much that this change causes permanent web accesses to non-JOSM servers for elements which are not users-selected. We're giving a telemetry of user actions this way to providers we haven't under control.

→ ticket:16542#comment:9

Replying to Don-vip:

I'm not sure the new Tag2Link class fits in the gui/util package, there is nothing related to Swing here.

Done in r15702.

Replying to Don-vip:

It would probably fit better in tools package. There are also a few SonarQube issues introduced: https://josm.openstreetmap.de/sonar/project/issues?id=josm&open=AW-Ruc2pdKVGF04AqhG2&resolved=false&sinceLeakPeriod=true&types=BUG

Fixed in r15701.

Replying to Don-vip:

The search engine should also be configurable, we can't force JOSM users to use DuckDuckGo. It can be the default but we should also propose Qwant, Bing and Google.

→ #18555

[Klumbumbus]

Replying to simon04:

→ ticket:16542#comment:9

(ticket:18542#comment:9 was meant)

[simon04]

JOSM/i18n: remove convtag2link – ​[o35307]