#13901 closed enhancement (fixed)
Add tag2link plugin to core
Reported by: | openstreetmap.org-user-d1g | Owned by: | simon04 |
---|---|---|---|
Priority: | normal | Milestone: | 20.01 |
Component: | Core tag2link | Version: | |
Keywords: | Cc: |
Description
There no better alternatives to what it does, right? If there no alternatives, simply include it in core?
Additionally it doesn't clutter main interface with menus and buttons, but provides context items.
Attachments (2)
Change History (28)
comment:1 Changed 3 years ago by
comment:2 Changed 3 years ago by
Milestone: | → 20.01 |
---|---|
Owner: | changed from team to simon04 |
Status: | new → assigned |
Summary: | tag2link -> core → Add tag2link plugin to core |
Changed 3 years ago by
Attachment: | mapcss-tag2link.patch added |
---|
comment:3 Changed 3 years ago by
Originally I planned to rewrite the functionality to a MapCSS based syntax. However, everything got so complex that I gave up. attachment:mapcss-tag2link.patch
To keep it simple, I implemented the rules as a plain Java function.
In r15673, I migrated the first half of the ruleset. The country specific rules (FR, NL, CZ) are outstanding.
comment:4 Changed 3 years ago by
I don't like the idea of maintaining these rules in Java code... Did you start to code #18542? It's a much better way for the OSM community (i.e: not us) to maintain the rules.
comment:7 Changed 3 years ago by
Component: | Core → Core tag2link |
---|
comment:11 Changed 3 years ago by
I noticed a problem (related to #14465): If you not all selected objects have key then you get additional links leading to nowhere other than the naked link, e.g. https://twitter.com/
Changed 3 years ago by
Attachment: | twitter.png added |
---|
comment:12 Changed 3 years ago by
Replying to Don-vip:
Why didn't you use
addSeparator()
?
Because I cannot remove that one in popupMenuWillBecomeInvisible
(since addSeparator
"returns" void
).
comment:13 Changed 3 years ago by
I don't like much that this change causes permanent web accesses to non-JOSM servers for elements which are not users-selected. We're giving a telemetry of user actions this way to providers we haven't under control.
comment:14 follow-up: 17 Changed 3 years ago by
I'm not sure the new Tag2Link class fits in the gui/util package, there is nothing related to Swing here. It would probably fit better in tools package. There are also a few SonarQube issues introduced: https://josm.openstreetmap.de/sonar/project/issues?id=josm&open=AW-Ruc2pdKVGF04AqhG2&resolved=false&sinceLeakPeriod=true&types=BUG
The search engine should also be configurable, we can't force JOSM users to use DuckDuckGo. It can be the default but we should also propose Qwant, Bing and Google.
comment:17 follow-up: 18 Changed 3 years ago by
Replying to Klumbumbus:
If you not all selected objects have key then you get additional links leading to nowhere other than the naked link, e.g. https://twitter.com/
Please check the tooltip – the links have different URLs, but their names/labels are indistinguishable. Let's continue in #14465.
Replying to stoecker:
I don't like much that this change causes permanent web accesses to non-JOSM servers for elements which are not users-selected. We're giving a telemetry of user actions this way to providers we haven't under control.
Replying to Don-vip:
I'm not sure the new Tag2Link class fits in the gui/util package, there is nothing related to Swing here.
Done in r15702.
Replying to Don-vip:
It would probably fit better in tools package. There are also a few SonarQube issues introduced: https://josm.openstreetmap.de/sonar/project/issues?id=josm&open=AW-Ruc2pdKVGF04AqhG2&resolved=false&sinceLeakPeriod=true&types=BUG
Fixed in r15701.
Replying to Don-vip:
The search engine should also be configurable, we can't force JOSM users to use DuckDuckGo. It can be the default but we should also propose Qwant, Bing and Google.
→ #18555
comment:18 Changed 3 years ago by
comment:19 Changed 3 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:22 Changed 3 years ago by
Needs documentation in the wiki, probably an own page wikitr:/Help/Action/Tag2Link and links from the other wiki pages.
comment:23 Changed 3 years ago by
Agreed. @Simon the new wikidata/sophox features need to be documented. I don't know myself where to go to add new rules, and what is the difference between the two endpoints.
comment:25 Changed 3 years ago by
Thanks, I changed internal links as wikitr:
is better for translation (wiki:/Help/Action/Tag2Link?action=diff&version=5)
In 15673/josm: