Modify ↓

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13828 closed defect (fixed)

attempted to open imagegeocentre imagery into Task 43 of 2102 - Suna East, Kenya

Reported by: andrewvhp@… Owned by: team
Priority: normal Milestone: 16.10
Component: Core imagery Version:
Keywords: template_report wms url Cc: michael2402

Description

What steps will reproduce the problem?

  1. Task open in JOSM
  2. click imagegeocentre imagery - either on offer

What is the expected result? Error message

What happens instead? I returned to Bing to complete the task

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-06 00:16:07 +0200 (Tue, 06 Sep 2016)
Build-Date:2016-09-05 22:21:00
Revision:10966
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10966 en_GB) Windows 8.1 64-Bit
Memory Usage: 263 MB / 891 MB (21 MB allocated, but free)
Java version: 1.8.0_111-b14, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1366x768
Maximum Screen Size: 1366x768
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\Downloads\josm (20).jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=49718, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (32944)
+ todo (30000)

Last errors/warnings:
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method
- W: Unable to use English input method


=== REPORTED CRASH DATA ===
MapView#layerAdded:
 - layer: WMSLayer [info=ImageryInfo{name='imagegeocenter.org:', countryCode='', url='http://imagegeocenter.org/image/rest/services/Dachudua_Milange/MapServer//tile/{z}/{y}/{x}?FORMAT=null&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}', imageryType=WMS}]

LayerManager#fireLayerAdded:
 - listener: org.openstreetmap.josm.gui.MapView[,0,0,752x611,alignmentX=0.0,alignmentY=0.0,border=,flags=0,maximumSize=,minimumSize=java.awt.Dimension[width=10,height=0],preferredSize=]
 - event: LayerAddEvent [addedLayer=WMSLayer [info=ImageryInfo{name='imagegeocenter.org:', countryCode='', url='http://imagegeocenter.org/image/rest/services/Dachudua_Milange/MapServer//tile/{z}/{y}/{x}?FORMAT=null&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}', imageryType=WMS}]]

BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-2 (58) of javawsApplicationThreadGroup
java.lang.IllegalArgumentException: {z} is not a valid WMS argument. Please check this server URL:
http://imagegeocenter.org/image/rest/services/Dachudua_Milange/MapServer//tile/{z}/{y}/{x}?FORMAT=null&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}
	at org.openstreetmap.josm.data.imagery.TemplatedWMSTileSource.checkUrl(TemplatedWMSTileSource.java:349)
	at org.openstreetmap.josm.gui.layer.WMSLayer.getTileSource(WMSLayer.java:85)
	at org.openstreetmap.josm.gui.layer.WMSLayer.getTileSource(WMSLayer.java:38)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer.initializeIfRequired(AbstractTileSourceLayer.java:697)
	at org.openstreetmap.josm.gui.layer.AbstractTileSourceLayer.attachToMapView(AbstractTileSourceLayer.java:678)
	at org.openstreetmap.josm.gui.MapView.layerAdded(MapView.java:652)
	at org.openstreetmap.josm.gui.layer.LayerManager.fireLayerAdded(LayerManager.java:379)
	at org.openstreetmap.josm.gui.layer.LayerManager.realAddLayer(LayerManager.java:191)
	at org.openstreetmap.josm.gui.layer.MainLayerManager.realAddLayer(MainLayerManager.java:267)
	at org.openstreetmap.josm.gui.layer.LayerManager.lambda$addLayer$0(LayerManager.java:180)
	at org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWaitWithException(GuiHelper.java:138)
	at org.openstreetmap.josm.gui.layer.LayerManager.addLayer(LayerManager.java:180)
	at org.openstreetmap.josm.actions.AddImageryLayerAction.actionPerformed(AddImageryLayerAction.java:72)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.AbstractButton.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (10)

comment:1 by wiktorn, 8 years ago

Cc: michael2402 added

@michael2402:

Can you have a look at this?

In AddImageryLayerAction.actionPerformed I expect to catch IllegalArgumentException but I guess that GuiHelper.runInEDTAndWaitWithException is wrapping it, so I can't extract this one.

Is the only way forward is to move to checked exceptions with this validation errors?

comment:2 by wiktorn, 8 years ago

Ticket #13837 has been marked as a duplicate of this ticket.

comment:3 by simon04, 8 years ago

Ticket #13533 has been marked as a duplicate of this ticket.

comment:4 by simon04, 8 years ago

Also related: #13264, #13741

comment:5 by simon04, 8 years ago

Resolution: → fixed
Status: new → closed

In 11168/josm:

fix #13828 - Fix IAE when adding WMS layer with invalid URL

The fix involves checking the URL when constructing WMSLayer instead when calling getTileSource

comment:6 by simon04, 8 years ago

Milestone: → 16.10

comment:7 by simon04, 8 years ago

In 11181/josm:

see #13828 - Fix unit test

comment:8 by wiktorn, 8 years ago

Ticket #13858 has been marked as a duplicate of this ticket.

comment:9 by Don-vip, 8 years ago

Ticket #13878 has been marked as a duplicate of this ticket.

comment:10 by Don-vip, 8 years ago

Component: Core → Core imagery
Keywords: wms url added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.