Modify

Opened 4 years ago

Closed 4 years ago

#13824 closed enhancement (fixed)

Add leisure=horse_riding to presets for sport=equestrian/horse_racing (?)

Reported by: Hufkratzer Owned by: team
Priority: normal Milestone: 16.10
Component: Internal preset Version: tested
Keywords: leisure horse_riding sport equestrian golf i18n Cc: Hufkratzer

Description

Issue

The current presets for sports equestrian and horse_racing do not offer to select leisure=horse_riding as physical feature for these sports, they only offer pitch, sports_centre, stadium and track.

Recently you have allowed to use leisure=horse_riding as physical feature for sport=* in the validator, see https://josm.openstreetmap.de/changeset/11133/josm

Wouldn't it make sense now to also add horse_riding to the presets for sport=equestrian/horse_racing? sport=equestrian is not really necessary together with leisure=horse_riding but it is often used and I think leisure=horse_riding is often a more suitable choice as a physical feature for sport=equestrian than leisure=sports_centre which is available.

Please compare with the presets for sport=golf which allow leisure=golf_course (German: Golfanlage) to be choosen, which corresponds to leisure=horse_riding
(German: Reitanlage).

Please also compare and review my corresponding suggestions for changing the following German translations in Launchpad:

I think the current translations are very confusing.

Please provide any additional information below. Attach a screenshot if possible.

will be added

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-06 00:16:07 +0200 (Tue, 06 Sep 2016)
Build-Date:2016-09-05 22:21:00
Revision:10966
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10966 de) Windows XP 32-Bit
Memory Usage: 123 MB / 989 MB (38 MB allocated, but free)
Java version: 1.8.0_91-b14, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 800x600
Maximum Screen Size: 800x600
Dataset consistency test: No problems found

Plugins:
+ PicLayer (32796)
+ apache-commons (32699)
+ scripting (30760)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/MTB&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1

Attachments (5)

pferdesport.jpg (21.3 KB) - added by Hufkratzer 4 years ago.
German presets for sport=equestrian
golf.jpg (46.9 KB) - added by Hufkratzer 4 years ago.
Suggested translation change: Golfplatz -> Golf (non-physical)
pferdesport2.jpg (49.0 KB) - added by Hufkratzer 4 years ago.
Suggested translation change: Reitplatz -> Pferdesport
golf2.jpg (13.6 KB) - added by Hufkratzer 4 years ago.
Suggested translation change: Golfplatz -> Golf (non-physical)
josm-11148-horse_riding.jpg (29.8 KB) - added by Hufkratzer 4 years ago.
presets for sprot=equestrian in josm 11148

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by Hufkratzer

Attachment: pferdesport.jpg added

German presets for sport=equestrian

Changed 4 years ago by Hufkratzer

Attachment: golf.jpg added

Suggested translation change: Golfplatz -> Golf (non-physical)

Changed 4 years ago by Hufkratzer

Attachment: pferdesport2.jpg added

Suggested translation change: Reitplatz -> Pferdesport

Changed 4 years ago by Hufkratzer

Attachment: golf2.jpg added

Suggested translation change: Golfplatz -> Golf (non-physical)

comment:1 Changed 4 years ago by Hufkratzer

Keywords: golf i18n added

comment:2 Changed 4 years ago by Hufkratzer

Oh, the preset enhancement seems to be already in the current development version 11148, I should have checked that earlier. But please correct the German translations.

Changed 4 years ago by Hufkratzer

Attachment: josm-11148-horse_riding.jpg added

presets for sprot=equestrian in josm 11148

comment:3 in reply to:  2 Changed 4 years ago by Klumbumbus

Milestone: 16.10

Replying to Hufkratzer:

Oh, the preset enhancement seems to be already in the current development version 11148

No, not yet. It appears in your list because you already have an object tagged this way in your local data file and you already opened the preset window with this value included.

I reviewed the german translations. They will be part of next stable release.

comment:4 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 11153/josm:

  • add display_values and values_sort=false for Route network values (iwn,nwn,...)
  • warn about missing sport key on pitches
  • see #13804 - group unnecessary tag warnings
  • add own colors for sport=multi|running|athletics to avoid false positive validator warning in stadiums (inner style equals MP style)
  • fix #13824 - adjust sport=equestrian|horse_racing presets

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.