View menu items are not disabled after last OSM data layer was removed

[openstreetmap.org-user-d1g]

What steps will reproduce the problem?

1. create New layer
2. remove it

What is the expected result?

Items in "Help/Menu/View" menu should be disabled, because there nothing to view/zoom/pan

What happens instead?

Items 4 and 5 are normal buttons

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-01 20:56:44 +0200 (Thu, 01 Sep 2016)
Build-Date:2016-09-02 01:33:38
Revision:10929
Relative:URL: ^/trunk

[Klumbumbus]

Do you mean "zoom in" and "zoom out"?

[Don-vip]

@Michael: ZoomInAction.updateEnabledState() is called during layerRemoving event. At this time Main.getLayerManager().getLayers() is not (yet) empty. What's the best way to fix this?

[michael2402]

There are several options for that:

• Register a LayerAvailabilityListener if we want to know if any layer is present or not (I prefer this one)
• Register a ActiveLayerChangeListener if the option depends on the active layer (which may be null).
• Use isLastLayer() on the LayerRemoveEvent to see if the last layer was removed. (quick, dirty)

The nice way would be to have a unified way for all menus to be disabled if all items are disabled. Then the menu items can simply be disabled. This is what I did in my main menu branch. We could bind the zoom actions directly to the map view and add them whenever the map view is added to the view, remove them otherwise.

[Don-vip]

Replying to michael2402:

The nice way would be to have a unified way for all menus to be disabled if all items are disabled. Then the menu items can simply be disabled. This is what I did in my main menu branch.

OK let's fix this in next milestone then.

[simon04]

Milestone renamed

[Don-vip]

Milestone renamed

[Don-vip]

This has been fixed in r10998.