Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13268 closed defect (fixed)

jenkins presets test goes wild

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 16.07
Component: Unit tests Version:
Keywords: regression Cc:

Description

The last tests of https://josm.openstreetmap.de/jenkins/job/JOSM/lastCompletedBuild/jdk=JDK8/testReport/org.openstreetmap.josm.gui.preferences.map/TaggingPresetPreferenceTestIT/testValidityOfAvailablePresets/ are strange.

It displays presets with icon errors as OK (e.g.
http://www.openrailwaymap.org/josm-presets/de.zip) and correct presets as KO (e.g. https://josm.openstreetmap.de/wiki/Presets/Czech_Slovak_addresses). Maybe this is due to java.lang.IllegalArgumentException: MALFORMED (I don't know where this comes from.)

And now there is a new error Error processing jar:file:/var/lib/jenkins/jobs/JOSM/workspace/jdk/JDK8/dist/josm-custom.jar!/images/presets/service/ Premature end of file.

Attachments (0)

Change History (7)

comment:1 Changed 3 years ago by Don-vip

Resolution: fixed
Status: newclosed

cache was outdated, I changed the jenkins jobs to clear cache before running tests.

comment:2 Changed 3 years ago by Klumbumbus

Ok, but what happend to the images/presets/service folder?
styles jenkins test has this error too:

[Fatal Error] :1:1: Premature end of file.
Error processing jar:file:/var/lib/jenkins/jobs/JOSM/workspace/jdk/JDK8/dist/josm-custom.jar!/images/presets/service/
Premature end of file.

comment:3 Changed 3 years ago by Don-vip

I have no idea, I got the same message on my PC, don't know where it comes from

comment:4 Changed 3 years ago by Don-vip

Resolution: fixed
Status: closedreopened

bug found, investigating

comment:5 Changed 3 years ago by Don-vip

The problem comes from telephone.svg:

TRACE: createImageFromSvg: file:/C:/SVN/josm/core/bin2/images/presets/social_facility/food_bank.svg java.awt.Dimension[width=-1,height=16]
TRACE: createImageFromSvg: file:/C:/SVN/josm/core/bin2/images/presets/social_facility/food_bank.svg java.awt.Dimension[width=-1,height=24]

TRACE: createImageFromSvg: file:/C:/SVN/josm/core/bin2/images/presets/service/telephone.svg java.awt.Dimension[width=-1,height=16]
[Fatal Error] :1:1: Content is not allowed in prolog.
Error processing file:/C:/SVN/josm/core/bin2/images/presets/service/
Content is not allowed in prolog.
TRACE: createImageFromSvg: file:/C:/SVN/josm/core/bin2/images/presets/service/telephone.svg java.awt.Dimension[width=-1,height=24]
[Fatal Error] :1:1: Content is not allowed in prolog.
Error processing file:/C:/SVN/josm/core/bin2/images/presets/service/
Content is not allowed in prolog.

TRACE: createImageFromSvg: file:/C:/SVN/josm/core/bin2/images/presets/service/toilets.svg java.awt.Dimension[width=16,height=-1]
TRACE: createImageFromSvg: file:/C:/SVN/josm/core/bin2/images/presets/service/toilets.svg java.awt.Dimension[width=24,height=-1]

comment:6 Changed 3 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 10767/josm:

fix #13268 - fix error in telephone.svg

comment:7 Changed 3 years ago by Klumbumbus

Thanks. I don't know why inskape inserted this. If I remember correctly in https://josm.openstreetmap.de/changeset/10724/josm/trunk/images/presets/service/telephone.svg I just changed the stroke width a bit.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.