Modify

Opened 4 years ago

Closed 4 years ago

#13239 closed enhancement (fixed)

[Patch] Java 8: MapCSS Condition class

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.07
Component: Core mappaint Version:
Keywords: gsoc-core java8 Cc: Don-vip, bastiK, stoecker

Description

The switch/case in conditions can be removed by using lambda expressions

The speed is not affected by this (the JIT can produce similar assembly code in both cases)

I noticed a small decrease in floating point performance, I think this happens because of the nested lambdas. It is less than 5%, so probably OK.

Performance of EQ seems to have improved extremely (~4 times compared to NEQ). This is because of the JIT thinking that that call is special and optimizing/inlining it. If you change the order of the Ops that are used before the JIT jumps in, you get an other fast entry ;-).

Attachments (1)

patch-mapcss-java8-condition.patch (17.7 KB) - added by michael2402 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by michael2402

comment:1 Changed 4 years ago by Don-vip

Milestone: 16.0816.07

comment:2 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10674/josm:

fix #13239, fix #13240 - Java 8: MapCSS Condition class (patches by michael2402) - gsoc-core

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.