Modify

Opened 4 years ago

Closed 4 years ago

#13240 closed enhancement (fixed)

[Patch] Tests for MapCSS condition class

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.07
Component: Core mappaint Version:
Keywords: gsoc-core performance Cc: Don-vip, bastiK, stoecker

Description

  • New test for the Condition class
  • New test to check the Op performance

Performance test fails in current version since NREGEX does not handle null values correctly. If you want to compare them, simply replace it with "".

Test results:

<measurement><name>Condition.Op.EQ</name><value>1.0</value></measurement>
<measurement><name>Condition.Op.NEQ</name><value>7.5</value></measurement>
<measurement><name>Condition.Op.GREATER_OR_EQUAL</name><value>37.5</value></measurement>
<measurement><name>Condition.Op.GREATER</name><value>38.75</value></measurement>
<measurement><name>Condition.Op.LESS_OR_EQUAL</name><value>37.75</value></measurement>
<measurement><name>Condition.Op.LESS</name><value>37.5</value></measurement>
<measurement><name>Condition.Op.REGEX</name><value>29.0</value></measurement>
<measurement><name>Condition.Op.NREGEX</name><value>29.0</value></measurement>
<measurement><name>Condition.Op.ONE_OF</name><value>37.5</value></measurement>
<measurement><name>Condition.Op.BEGINS_WITH</name><value>7.5</value></measurement>
<measurement><name>Condition.Op.ENDS_WITH</name><value>9.0</value></measurement>
<measurement><name>Condition.Op.CONTAINS</name><value>13.0</value></measurement>

Attachments (1)

patch-test-mapcss-condition.patch (20.9 KB) - added by michael2402 4 years ago.

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by michael2402

comment:1 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10674/josm:

fix #13239, fix #13240 - Java 8: MapCSS Condition class (patches by michael2402) - gsoc-core

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.