Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12916 closed defect (fixed)

Islet size computed wrong

Reported by: Jojo4u Owned by: team
Priority: normal Milestone: 16.06
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. File -> Download object ... -> https://www.openstreetmap.org/way/308481263
  2. Run Validator

What is the expected result?

The feature has an area 1700m², well below the 1 km² for place=island. No warning should be displayed.

What happens instead?

"place=islet on large area, use place=island instead" warning is displayed.

Please provide any additional information below. Attach a screenshot if possible.

Probably the areasize comparison of place=islet is botched, a km² is one million m²!

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-06-04 17:28:58 +0200 (Sat, 04 Jun 2016)
Build-Date:2016-06-04 15:31:27
Revision:10327
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10327 en) Linux Arch Linux
Memory Usage: 575 MB / 814 MB (230 MB allocated, but free)
Java version: 1.8.0_92-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Djosm.restart=true]
Dataset consistency test: No problems found

Plugins:
- BuildingGeneralization (UNKNOWN)
- FixAddresses (32158)
- HouseNumberTaggingTool (31926)
- Mapillary (32158)
- OpeningHoursEditor (32158)
- RoadSigns (32177)
- alignways (32161)
- apache-commons (32158)
- apache-http (32158)
- buildings_tools (32158)
- download_along (32158)
- ebdirigo (0.0.2)
- editgpx (32158)
- geochat (32158)
- graphview (32158)
- gson (32158)
- imagery_offset_db (32158)
- jogl (1.0.46)
- kendzi3d (1.0.190.1)
- kendzi3d-resources (0.0.1)
- log4j (32158)
- mapdust (31923)
- measurement (32158)
- public_transport (32158)
- public_transport_layer (32158)
- reverter (32158)
- tageditor (32158)
- todo (29154)
- tofix (1464643236)
- turnlanes (32158)
- turnrestrictions (32158)
- undelete (32158)
- utilsplugin2 (32158)
- waydownloader (32158)
- wikipedia (32182)

Tagging presets:
- http://www.country-linedance.de/daten/Archaeologie-de.zip
- http://www.country-linedance.de/daten/Verkehrszeichen-vorlage.zip
- http://www.openrailwaymap.org/<user.name>sm-presets/de.xml
- http://zibi.openstreetmap.org.pl/kendzi/k/Simple3dPreset/s3db-preset.zip
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/BuildingPreset&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Bus_lanes&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/CampingForOverlanders&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Communication_Towers&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Crafts&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/LaneAttributes&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Maxspeed-zones&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/NewParkingFeatures&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/NewTags&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/OneClick&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/ParkingLanes&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/PublicTransportOneClick&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Quick-highways&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Quick-stops&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/SentieriItaliani&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Towers&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/Traffic_signs&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Presets/hiking_routes_with_trail_marking&zip=1
- https://raw.githubusercontent.com/OpenSeaMap/<user.name>sm/master/Presets_Hafen.xml

Map paint styles:
- <<user.name>sm.pref>/ebdirigo/style.zip
- https://dl.dropbox.com/u/8010189/Forum%20attachments/Hide_nodes.mapcss
- https://github.com/gmgeo/osmic-<user.name>sm-style/archive/master.zip
- https://github.com/simon04/coloured-addresses.mapcss/raw/master/dist/coloured-addresses.mapcss
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/AddressValidator&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/BesideTheRoad_Speed&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Cycleways&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Fixme&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Highway_Nodes&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Lane_features&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Lane_features_ryg&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/LessObtrusiveNodes&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Lit&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/LitObjects&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Maxspeed&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/MaxspeedIcons&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/NewParkingFeatures&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Noname&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/ParkingLanes&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/Sidewalks&style&zip=1
- https://<user.name>sm.openstreetmap.de/<user.name>smfile?page=Styles/SlovakiaBicycleRoutes&zip=1

Last errors/warnings:
- E: No tagging preset submenu for   
- E: No tagging preset submenu for   
- E: org.openstreetmap.<user.name>sm.io.IllegalDataException: Line 1 column 1: Premature end of file.. Cause: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[1,1]
- E: Error - <html>Could not read file 'Data Layer 4_20160605_194815664.osm'.<br>Error is:<br>Line 1 column 1: Premature end of file.</html>
- E: org.openstreetmap.<user.name>sm.plugins.PluginException: An error occurred in plugin ebdirigo. Cause: java.lang.reflect.InvocationTargetException. Cause: java.lang.IllegalArgumentException: Listener already registered.

Attachments (0)

Change History (6)

comment:1 by Jojo4u, 10 years ago

Summary: Islet size computed wrontIslet size computed wrong

comment:2 by Klumbumbus, 10 years ago

Milestone: 16.06

comment:3 by Don-vip, 10 years ago

areasize results are in square meters.

comment:4 by Klumbumbus, 10 years ago

Resolution: fixed
Status: newclosed

In 10328/josm:

fix #12916, see #12496 - fix islet/island size warning

comment:5 by Klumbumbus, 10 years ago

Thanks. Strange that nobody noticed it before :)

comment:6 by bastiK, 10 years ago

<<user.name>sm.pref>/ebdirigo/style.zip

User name obfuscation is a bit overzealous here. ;-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.