Modify

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#12496 closed enhancement (fixed)

Verify properly tagged islands and islets

Reported by: naoliv Owned by: team
Priority: normal Milestone: 16.02
Component: Core validator Version:
Keywords: mapcss island islet place Cc:

Description

http://wiki.openstreetmap.org/wiki/Key:place#Other_places says:

place=island → area > 1 km²
place=islet → area < 1 km²

area:closed[place = islet][eval(areasize()) > 1000] {
        throwWarning: tr("islet with wrong classification");
        suggestAlternative: "place=island";
        fixAdd: "place=island";
}

area:closed[place = island][eval(areasize()) < 1000] {
        throwWarning: tr("island with wrong classification");
        suggestAlternative: "place=islet";
        fixAdd: "place=islet";
}

island|islet with exactly 1 km² is in limbo.
It needs a better warning message, probably.

But it needs to have #11516 fixed to also work with relations.

Is it interesting to have this test in JOSM?

Attachments (0)

Change History (8)

comment:1 Changed 4 years ago by bastiK

Wiki page Tag:place=islet:

An islet is a very small island with an area less than about 1 km².

The size is only a guiding value, there should be some tolerance.

comment:2 Changed 4 years ago by naoliv

Or at info level, saying that the place should probably be island|islet

comment:3 Changed 4 years ago by Klumbumbus

What about change the values to 500 and 1500?

area:closed[place = islet][eval(areasize()) > 1500] {
        throwWarning: tr("{0} on a large area", "{1.tag}");
        suggestAlternative: "place=island";
        fixAdd: "place=island";
}

area:closed[place = island][eval(areasize()) < 500] {
        throwWarning: tr("{0} on a small area", "{1.tag}");
        suggestAlternative: "place=islet";
        fixAdd: "place=islet";
}

comment:4 in reply to:  3 Changed 4 years ago by Don-vip

Keywords: island islet place added
Milestone: 16.02

Replying to Klumbumbus:

What about change the values to 500 and 1500?

sounds nice

comment:5 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 9843/josm:

fix #12496 - Verify properly tagged islands and islets (modified patch by naoliv)

comment:6 Changed 3 years ago by Klumbumbus

In 10328/josm:

fix #12916, see #12496 - fix islet/island size warning

comment:7 Changed 3 years ago by anonymous

What are these 500 and 1500?? I have an islet ~7500m² that's 0.0075km² and validator is suggesting place=island
josm version 10327

comment:8 in reply to:  7 Changed 3 years ago by anonymous

Replying to anonymous:

What are these 500 and 1500?? I have an islet ~7500m² that's 0.0075km² and validator is suggesting place=island
josm version 10327

Ok, there is new values in 10328. I should have read all the coments.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.