Modify

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#12834 closed enhancement (invalid)

"Route relation contains a gap" validator needs to assume lack of duplicate ways

Reported by: Kjarrval Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description (last modified by Kjarrval)

The validator, when testing route relations, produces the validation error "route relation contains a gap" when the ways in the relations don't connect all the way in their defined order. Since JOSM has the rule of disabling adding of duplicate members to relations, some routes cannot be fixed (within JOSM). However, the validator is perfectly willing to let relations with duplicate ways pass the validation as long as the duplicate ways were already in the server data. This creates an imbalance where the error must be left alone or the user must use another editor for that task.

There are two ways I can think of to make it more fair:
1) Allow adding of duplicate members again, and/or
2) Enhance the validation check so it will forgive the lack of duplicate members in route relations.

Attachments (0)

Change History (5)

comment:1 by Kjarrval, 8 years ago

Description: modified (diff)

comment:2 by Kjarrval, 7 years ago

Resolution: invalid
Status: newclosed

comment:3 by skyper, 7 years ago

Warnings are no errors and have a higher possibility of false positives (e.g. circles of route relations) and need not be fixed all the time.

The validation before upload includes only created and/or modified objects if you want to validate the whole data set just run validator manually without selecting any object in advance.

in reply to:  description ; comment:4 by Klumbumbus, 7 years ago

Replying to Kjarrval:

1) Allow adding of duplicate members again

It is possible to add elements multiple times to an relation. Maybe you once answered the question of JOSM if you really want to do this with "no" and checked "don't ask me again". There is currently no GUI to reset this. See ticket:12159#comment:3 how to reset it.

in reply to:  4 comment:5 by Kjarrval, 7 years ago

Replying to Klumbumbus:

Replying to Kjarrval:

1) Allow adding of duplicate members again

It is possible to add elements multiple times to an relation. Maybe you once answered the question of JOSM if you really want to do this with "no" and checked "don't ask me again". There is currently no GUI to reset this. See ticket:12159#comment:3 how to reset it.

I discovered this only yesterday and managed to find the advanced preferences entry. That's why I modified the resolution by setting it to invalid.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.