Modify

Opened 5 years ago

Closed 10 months ago

#12835 closed defect (invalid)

merge overlap isn't removing the overlapping way anymore (nor creating multipolygons)

Reported by: naoliv Owned by: team
Priority: major Milestone:
Component: Plugin merge-overlap Version:
Keywords: multipolygon Cc:

Description

With the attached example file, select both polygons and then run merge overlap.

Start noticing one thing: it asks how we want to solve the natural key conflict (while in fact it shouldn't, since the shared way won't have any tag).

Choose any value and apply.

Where the ways were overlapped note how we now have 2 ways (while we should have only one way + 2 multipolygons).

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-05-10 01:31:36 +0200 (Tue, 10 May 2016)
Build-Date:2016-05-10 01:33:17
Revision:10171
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10171 en) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 247 MB / 4029 MB (92 MB allocated, but free)
Java version: 1.8.0_91-8u91-b14-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (31772)
- Create_grid_of_ways (31772)
- FastDraw (31895)
- FixAddresses (31772)
- OpeningHoursEditor (31772)
- PicLayer (31895)
- SimplifyArea (31895)
- apache-commons (31895)
- buildings_tools (31895)
- download_along (31772)
- editgpx (32148)
- ejml (31895)
- geotools (31895)
- graphview (31895)
- jogl (1.0.46)
- jts (31772)
- kendzi3d (1.0.190.1)
- kendzi3d-resources (0.0.1)
- log4j (31895)
- measurement (31895)
- merge-overlap (31967)
- opendata (32139)
- pdfimport (32019)
- photo_geotagging (31895)
- poly (31772)
- reverter (32005)
- tagging-preset-tester (31895)
- todo (29154)
- turnrestrictions (31895)
- undelete (31895)
- utilsplugin2 (32099)

Attachments (2)

example.osm (1.1 KB) - added by naoliv 5 years ago.
expected.osm (1.4 KB) - added by naoliv 10 months ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by naoliv

Attachment: example.osm added

comment:1 Changed 2 years ago by Don-vip

Keywords: multipolygon added

comment:2 Changed 10 months ago by GerdP

I tried to find a description reg. this plugin. I have no idea what the expected result is.

Changed 10 months ago by naoliv

Attachment: expected.osm added

comment:3 Changed 10 months ago by naoliv

Still using the above example, select both areas and then Merge overlap

JOSM with then display this:

https://i.imgur.com/2BpLxPB.png

What I would expect is to have the two overlapping parts merged into one, without being asked about anything (and left without any value).
This new common way should shared with/by both areas (using 2 multipolygons also automatically created by the plugin).

See expected.osm for the expected result.
I don't know if creating two multipolygons like this is still fully within the purposes of the plugin, however.

comment:4 Changed 10 months ago by GerdP

I see no hint in the source that this plugin could create a multipolygon relation.

comment:5 Changed 10 months ago by naoliv

And I honestly don't remember why I created this ticket with priority Major. At least looking at that priority now it is very unreasonable. Sorry.

Do you mind if I convert this ticket to enhancement? (so that one day, who knows, it might be possible to overlap ways shared by areas, already dealing with relations/multipolygons, etc)

comment:6 Changed 10 months ago by GerdP

I think what you are looking for is implemented in the reltoolbox plugin

comment:7 Changed 10 months ago by GerdP

Resolution: invalid
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.