Warnings if using Style "Adress Tags Validator"

[wernerschka]

What steps will reproduce the problem?

1. use the map style "Adress Tags Validator"
2. change some tag of the *relation* of a building with a *courtyard*. For example change the housenumber of the following farm house:

​https://www.openstreetmap.org/relation/5988163

3. When trying to upload the result to OSM, you'll get an annoying warning:

"With the currently used mappaint style(s) the style for outer way mismatches polygon" or in German: "Mit dem aktuell verwendeten Kartenstil passt der Stil des äußeren Weges nicht zum Polygon"

What is the expected result?

No Warning at all. I don't know what it should warn from. Rather it is pretending mappers, that something is wrong and should be fixed which isn't true.

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

This warning just occurs on Buildings with a Courtyard and just if some tag of the Multipolygon *Relation* is changed. If you just move the outer or inner line, no warning occurs.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-06 17:30:31 +0100 (Wed, 06 Jan 2016)
Build-Date:2016-01-06 16:32:31
Revision:9329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9329 de) Windows 7 32-Bit
Memory Usage: 199 MB / 989 MB (41 MB allocated, but free)
Java version: 1.8.0_73, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugins:
- HouseNumberTaggingTool (31772)
- buildings_tools (31895)
- undelete (31895)

[stoecker]

Can you try "Coloured Streets" style instead. Seems like the "Address Tags Validator" is an older style doing the same.

[Klumbumbus]

Yes, the "Address Tags Validator" wrongly also colours the inner yard, which leads to this warning.

[wernerschka]

You are right, "Coloured Streets" seems to be a good alternative style and it is not producing any Warnings on buildings with a courtyard.

But what is the reason for this warning anyway, whats the Problem if an inner yard is wrongly coloured?
And could the "Adress Tags Validator"-style be fixed of this bug? I'm sure, some mappers are using it and also wonder about these strange Warnings.

[Klumbumbus]

Maybe I was wrong with the colouring of the inner.

Anyway, the warning should warn for cases, where you have a multipolygon and additional an tag on the outer way, which also is an "area type". E.g. if you would add shop=books to the outer way in your example.

However, I think we should lower this to info level, as this test tests resulting colors instead of tags. similar to r8045

[wernerschka]

Maybe I understood you wrong, but in my example I didn't add any tag to the outer or the inner line of the Multypolygon. All tags were connected with the Multipolygon itself, and still the warning came. So this warning has something to do with with a faulty CSS-Style and not with faulty tagging.

[Klumbumbus]

Replying to wernerschka:

So this warning has something to do with with a faulty CSS-Style and not with faulty tagging.

Right. However the test checks colors instead of tags. It is not perfect.

[Klumbumbus]

The problem is the combination of a not perfect validator test and a not perfect mappaint style :)

[Klumbumbus]

see also #11152

[stoecker]

Solution: Drop the style?

[Klumbumbus]

I fixed the style. However Styles/Coloured_Streets is much more advanced, you should switch.

The validator warning should be info level, as it can produce false positives. E.g. a multipolygon building (with an inner yard) and tourism=museum on the outer (when the inner yard is part of the museum).

[Klumbumbus]

In 9834/josm:

fix #12541 - downgrade "style for outer way mismatches polygon" warning to info level to avoid false positives and clarify the message