Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12440 closed enhancement (fixed)

Keyboard shortcuts is not really readable on Mac

Reported by: ggeldenhuis Owned by: ggeldenhuis
Priority: normal Milestone: 16.02
Component: Core Version:
Keywords: macosx Cc:

Description (last modified by Don-vip)

When adding a tag the keyboard shortcuts is difficult to make out and could be larger and better displayed.


URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-06 17:30:31 +0100 (Wed, 06 Jan 2016)
Build-Date:2016-01-06 16:32:31
Revision:9329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9329 en) Mac OS X 10.11.2
Memory Usage: 577 MB / 3641 MB (317 MB allocated, but free)
Java version: 1.8.0_40, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Attachments (5)

Screen Shot 2016-01-24 at 18.19.53 (2).png (3.0 MB) - added by ggeldenhuis 3 years ago.
addtags.png (174.7 KB) - added by Don-vip 3 years ago.
Screen Shot 2016-01-30 at 6.45.52 PM.png (44.8 KB) - added by codesman 3 years ago.
addtags-patched.png (44.8 KB) - added by codesman 3 years ago.
josm-12440-1.patch (2.2 KB) - added by codesman 3 years ago.

Change History (13)

Changed 3 years ago by ggeldenhuis

Changed 3 years ago by Don-vip

Attachment: addtags.png added

comment:1 Changed 3 years ago by Don-vip

Description: modified (diff)
Keywords: macosx added

comment:2 Changed 3 years ago by Don-vip

can you please update to latest Java (8u72) and post a new screenshot?

comment:3 Changed 3 years ago by Don-vip

Owner: changed from team to ggeldenhuis
Status: newneedinfo

comment:4 Changed 3 years ago by codesman

JOSM 9329
Java Version 1.8.0_72
OS X 10.11.2

http://s28.postimg.org/9yk66u24t/Screen_Shot_2016_01_30_at_3_24_52_PM.png

Changed 3 years ago by codesman

Changed 3 years ago by codesman

Attachment: addtags-patched.png added

Changed 3 years ago by codesman

Attachment: josm-12440-1.patch added

comment:5 Changed 3 years ago by codesman

I'm a noob at Java. Poking around, trying to learn stuff!

I believe I found the culprit for this in josm/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

The shortcut key symbols are wrapped in an HTML <code> element.

According to MDN: "The HTML Code Element (<code>) represents a fragment of computer code. By default, it is displayed in the browser's default monospace font."

These Key Shortcuts do not represent fragments of code, they are UI elements/symbols. Wrapping them in an element that uses a monospace font removes all of the presentational goodness that they need to be sized/spaced correctly! Perhaps the + symbols could be sized smaller or grayed because they do not represent keys, but the symbols that represent keys to be pushed should be presented full size, IMO.

I've created a patch that removes the <code> elements and also adds some padding. Looks like this:

http://s11.postimg.org/ruwvrnd43/addtags_patched.png

Not quite awesome, but definitely an improvement. Don't know how this effects rendering in Linux or Windows, but I believe it is semantically incorrect to use the <code> element regardless.

comment:6 Changed 3 years ago by stoecker

Milestone: 16.02

comment:7 Changed 3 years ago by simon04

Resolution: fixed
Status: needinfoclosed

In 9699/josm:

fix #12440 - Add tag: Keyboard shortcuts is not really readable on Mac (patch by codesman)

comment:8 Changed 3 years ago by simon04

Great work! I changed the insets to 5,5,5,5 to be in line with the components above.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ggeldenhuis.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.