Keyboard shortcuts is not really readable on Mac

[ggeldenhuis]

When adding a tag the keyboard shortcuts is difficult to make out and could be larger and better displayed.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-06 17:30:31 +0100 (Wed, 06 Jan 2016)
Build-Date:2016-01-06 16:32:31
Revision:9329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9329 en) Mac OS X 10.11.2
Memory Usage: 577 MB / 3641 MB (317 MB allocated, but free)
Java version: 1.8.0_40, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

[Don-vip]

can you please update to latest Java (8u72) and post a new screenshot?

[codesman]

JOSM 9329
Java Version 1.8.0_72
OS X 10.11.2

[codesman]

I'm a noob at Java. Poking around, trying to learn stuff!

I believe I found the culprit for this in josm/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

The shortcut key symbols are wrapped in an HTML <code> element.

According to ​MDN: "The HTML Code Element (<code>) represents a fragment of computer code. By default, it is displayed in the browser's default monospace font."

These Key Shortcuts do not represent fragments of code, they are UI elements/symbols. Wrapping them in an element that uses a monospace font removes all of the presentational goodness that they need to be sized/spaced correctly! Perhaps the + symbols could be sized smaller or grayed because they do not represent keys, but the symbols that represent keys to be pushed should be presented full size, IMO.

I've created a patch that removes the <code> elements and also adds some padding. Looks like this:

Not quite awesome, but definitely an improvement. Don't know how this effects rendering in Linux or Windows, but I believe it is semantically incorrect to use the <code> element regardless.

[simon04]

In 9699/josm:

fix #12440 - Add tag: Keyboard shortcuts is not really readable on Mac (patch by codesman)

[simon04]

Great work! I changed the insets to 5,5,5,5 to be in line with the components above.