Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12439 closed defect (needinfo)

Incomplete role elements in preset for hiking routes

Reported by: simon@… Owned by: simon@…
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: Cc: simon04

Description (last modified by Don-vip)

The entry for hiking routes contains the following role elements

<role key="" text="route segment" requisite="required" type="way,closedway" member_expression="highway|route=ferry"/>
<role key="" text="infrastructure" requisite="optional" type="node,closedway" member_expression="tourism OR amenity"/>
<role key="" text="natural" requisite="optional" type="node,closedway" member_expression="natural=peak OR natural=volcano OR mountain_pass=yes OR natural=water OR tourism=viewpoint OR amenity=drinking_water OR natural=spring OR place=locality"/>

IMHO this does not make a lot of sense either there are role keys for the members or there aren't and then likely the role entries should be dropped.

Attachments (0)

Change History (6)

comment:1 by stoecker, 10 years ago

Owner: changed from team to simon@…
Status: newneedinfo

I don't understand what you want?

comment:2 by Don-vip, 10 years ago

Description: modified (diff)

comment:3 by Don-vip, 10 years ago

Cc: simon04 added

For reference, this has been added in r6810 to fix #9586

comment:4 by Klumbumbus, 10 years ago

Do you mean that the role column in the table in the preset window is empty?

comment:5 by Don-vip, 10 years ago

Resolution: needinfo
Status: needinfoclosed

comment:6 by Klumbumbus, 10 years ago

I think I understand now what he means: remove key="" because it is a bit superflous and can be assumed as default if no key is set in the preset code. (however according to TaggingPresets key is a required attribute)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon@….
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.