Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12363 closed enhancement (fixed)

[patch] layer context menus were different at two locations

Reported by: kolesar Owned by: team
Priority: normal Milestone: 16.02
Component: Core imagery Version:
Keywords: Cc:

Description (last modified by kolesar)

Right click menu on a map tile had "Snap to tile size" while popup menu in layer dialog had "Zoom to native resolution". The two actions did the same thing but was implemented twice.

There were items in both menus that had been missing from the another, combined them to be similar to each other in the same order. Some menu items had All Words Uppercased while others not, unified them.

Toggling [x] Show errors did not redraw map, it was confusing, fixed.

Item named "Change resolution" was also confusing and did nothing. This calls setZoomLevel(getBestZoom()) so that can be used as manual control when auto zoom is disabled. When auto zoom is enabled (that is enabled by default) it makes no sense. I have disabled this menu entry when auto zoom is enabled or current zoom is same as it would set to. Redraw was also missing, fixed.

The same issue was increase zoom and decrease zoom: did nothing with default configuration of tested version 9329 on standard mapnik layer, just because auto zoom was enabled. Disabled these when auto zoom is enabled and also when reached max/min levels. getMinZoomLvl() did not use the same way to obtain limit as getMaxZoomLvl() did, fixed.

Enabling "Auto zoom" did not change resolution immediately, only after moving map, fixed. Same for "Auto load tiles".

Added menu separators to emphasize which items belong together in a group. Now all corresponding items have the same names and order in two popup menus.

Attached patch.

Attachments (1)

LayerPopupMenu.patch (16.1 KB) - added by kolesar 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by kolesar

Attachment: LayerPopupMenu.patch added

comment:1 Changed 3 years ago by Don-vip

Component: CoreCore imagery

comment:2 Changed 3 years ago by kolesar

Description: modified (diff)

comment:3 Changed 3 years ago by bastiK

Resolution: fixed
Status: newclosed

In 9464/josm:

applied #12363 - layer context menus were different at two locations (patch by kolesar)

comment:4 Changed 3 years ago by bastiK

Milestone: 16.02

Great work! :)

comment:5 Changed 3 years ago by Don-vip

In 9478/josm:

see #12363 - javadoc/checkstyle

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.