Changeset 9478 in josm

Timestamp:

2016-01-16T01:24:40+01:00 (9 years ago)

Author:

Don-vip

Message:

see #12363 - javadoc/checkstyle

File:

• trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java (modified) (10 diffs)

trunk/src/org/openstreetmap/josm/gui/layer/AbstractTileSourceLayer.java

@@ -22 +22 @@
 import java.io.File;
 import java.io.IOException;
-import java.lang.reflect.Field;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.text.SimpleDateFormat;
+import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
@@ -42 +41 @@
 import javax.swing.Action;
 import javax.swing.BorderFactory;
-import javax.swing.DefaultButtonModel;
 import javax.swing.JCheckBoxMenuItem;
 import javax.swing.JLabel;
@@ -88 +86 @@
 import org.openstreetmap.josm.io.WMSLayerImporter;
 import org.openstreetmap.josm.tools.GBC;
-import org.openstreetmap.josm.gui.widgets.PopupMenuLauncher;
 
 /**
@@ -377 +374 @@
     }
 
-    private class LoadTileAction extends AbstractAction {
+    private final class LoadTileAction extends AbstractAction {
 
         private LoadTileAction() {
@@ -431 +428 @@
         }
 
+        @Override
         public Component createMenuComponent() {
             JCheckBoxMenuItem item = new JCheckBoxMenuItem(this);
@@ -454 +452 @@
         }
 
+        @Override
         public Component createMenuComponent() {
             JCheckBoxMenuItem item = new JCheckBoxMenuItem(this);
@@ -582 +581 @@
             this.t = t;
         }
-    }
-
-    private class BooleanButtonModel extends DefaultButtonModel {
-        private final Field field;
-
-        BooleanButtonModel(Field field) {
-            this.field = field;
-        }
-
-        @Override
-        public boolean isSelected() {
-            try {
-                return field.getBoolean(AbstractTileSourceLayer.this);
-            } catch (IllegalArgumentException | IllegalAccessException e) {
-                throw new RuntimeException(e);
-            }
-        }
-
     }
 
@@ -662 +643 @@
     }
 
+    /**
+     * Tile source layer popup menu.
+     */
     public class TileSourceLayerPopup extends JPopupMenu {
+        /**
+         * Constructs a new {@code TileSourceLayerPopup}.
+         */
         public TileSourceLayerPopup() {
-
             for (Action a : getCommonEntries()) {
                 if (a instanceof LayerAction) {
@@ -1650 +1636 @@
     }
 
+    /**
+     * Returns the common menu entries.
+     * @return the common menu entries
+     */
     public Action[] getCommonEntries() {
         return new Action[] {
@@ -1759 +1749 @@
     public void downloadAreaToCache(final PrecacheTask precacheTask, List<LatLon> points, double bufferX, double bufferY) {
         final Set<Tile> requestedTiles = new ConcurrentSkipListSet<>(new Comparator<Tile>() {
+            @Override
             public int compare(Tile o1, Tile o2) {
                 return String.CASE_INSENSITIVE_ORDER.compare(o1.getKey(), o2.getKey());