Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12260 closed defect (fixed)

Table views with dark system theme

Reported by: arvid.nr+josm@… Owned by: team
Priority: normal Milestone: 15.12
Component: Core Version:
Keywords: template_report color Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Use Linux
  2. Set JOSM to use GTK+ "Look and feel" (Preferences -> Display Settings -> Look and Feel)
  3. Use a GTK+ theme with light text and dark background.
  4. Unreadable GUI in Preferences ->:
    1. Keyboard shortcuts: Note, the two entries there that are unreadable both appear to be related to plugins, one reads: "External Tool: scanaerial", the other reads "Menu: Commands". I figured this out by switching my system theme. I guess this might not be component core, but rather the repective plugins?
    2. Imagery preferences: The bing URL is white on green in both lists.
    3. Advanced preferences. Some (quite a few) entries are white on yellow?

I see a pattern in all these though, they are are table views. Hopefully they can be fixed together?

I have attached an image cutting out parts of these views (rather than attaching 4 separate screenshots).


What is the expected result?

Readable GUI in these views.

What happens instead?

Unreadable GUI.

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2015-12-30 21:26:57 +0100 (Wed, 30 Dec 2015)
Build-Date:2015-12-30 20:28:45
Revision:9223
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9223 en) Linux Debian GNU/Linux 8.2 (jessie)
Memory Usage: 1391 MB / 3568 MB (1107 MB allocated, but free)
Java version: 1.8.0_66-internal, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Djosm.restart=true, -Djosm.home=/home/arvid/.josm-latest, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (31772)
- CommandLine (31869)
- HouseNumberTaggingTool (31772)
- Mapillary (31884)
- OpeningHoursEditor (31772)
- PicLayer (31772)
- RoadSigns (31772)
- alignways (31772)
- apache-commons (31772)
- apache-http (31875)
- buildings_tools (31772)
- download_along (31772)
- ejml (31772)
- ext_tools (31772)
- geotools (31774)
- gpsblam (31772)
- gpxfilter (31772)
- graphview (31772)
- imagery_offset_db (31772)
- josm-plugin-opengl (1440156917)
- jts (31772)
- log4j (31879)
- measurement (31772)
- opendata (31772)
- rasterfilters (31772)
- routing (31772)
- terracer (31772)
- turnlanes (31772)
- turnrestrictions (31772)
- utilsplugin2 (31772)
- waydownloader (31772)

Attachments (1)

unreadable_tables.png (92.7 KB ) - added by arvid.nr+josm@… 9 years ago.

Download all attachments as: .zip

Change History (7)

by arvid.nr+josm@…, 9 years ago

Attachment: unreadable_tables.png added

comment:1 by anonymous, 9 years ago

Summary: Dark system themeTable views with dark system theme

comment:2 by Don-vip, 9 years ago

Description: modified (diff)
Keywords: color added
Milestone: 15.12

comment:3 by Don-vip, 9 years ago

Resolution: fixed
Status: newclosed

In 9224/josm:

fix #12260 - adjust colors contrast in preferences tables (imagery, shortcuts, advanced preferences)

comment:4 by anonymous, 9 years ago

The new build works fine. Can't find any more issues for now. Impressively quick fixing of all these issues!

comment:5 by Don-vip, 9 years ago

thanks for the feedback, it's a lot easier when bug reports are well written :)

comment:6 by anonymous, 9 years ago

It helps being a programmer myself, I know what I would need to fix it myself. (So the obvious solution is to only allow programmers to report bugs? ;)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.