[draft patch] Add golf preset + new popular tags

[Don-vip]

Last piece of work from #12135: add golf presets:

Tag (wiki)	Count (taginfo)	Decision
​golf=bunker	​64675
​golf=fairway	​24191

and these new tags:

Tag (wiki)	Count (taginfo)	Decision
​maintenance=gritting	​15620	Ignored Very local usage see taginfo map, and other (better) tags are availible
​old_railway_operator=PRR	​10038	Ignored (only US)
​power=portal	​10422	see #12297
​seasonal=yes	​14724	Added

Presets/Golf_Course contains very nice SVG icons we can reuse, as Klumbumbus said in #12135:

​I asked tumsi and he allows us to use the golf svg icons. He also maybe can create new icons if needed for the tags in Presets/Golf_Course, which do not have an icon. (I did not yet check the tags).

I wrote an initial patch:

data/defaultpresets.xml

@@ -4994 +4994 @@
   </group>  <!-- Facilities -->
   <group name="Sports" icon="styles/standard/sport/soccer.png">
     <group name="Sport Facilities" icon="presets/stadium.png">
+        <group name="Golf" icon="styles/standard/sport/golf.svg">
+                <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
+                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                          fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                          pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                    <space />
+                    <key key="leisure" value="golf_course" />
+                    <reference ref="name_oh_wheelchair" />
+                </item> <!-- Golf Course -->
+                <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
+                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
+                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
+                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
+                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
+                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
+                          ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
+                    <space />
+                    <key key="leisure" value="miniature_golf" />
+                    <reference ref="name_oh_wheelchair" />
+                </item> <!-- Miniature Golf -->
+            <separator/>
+            <item name="Teeing Ground" type="node,closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="tee" />
+            </item> <!-- Teeing Ground -->
+            <item name="Hole" name_context="golf" type="way,closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="hole" />
+                <text key="ref" text="Reference" />
+                <text key="par" text="Par" />
+                <optional>
+                    <text key="name" text="Name" />
+                </optional>
+            </item> <!-- Hole -->
+            <item name="Pin" name_context="golf" type="node" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="pin" />
+                <text key="ref" text="Reference" />
+            </item> <!-- Pin -->
+            <item name="Green" name_context="golf" type="closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
+                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
+                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
+                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
+                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
+                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
+                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
+                <space />
+                <key key="golf" value="green" />
+            </item> <!-- Green -->
+            <item name="Bunker" name_context="golf" type="closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=bunker" />
+                <space />
+                <key key="golf" value="bunker" />
+            </item> <!-- Bunker -->
+            <item name="Fairway" name_context="golf" type="closedway" preset_name_label="true">
+                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=fairway" />
+                <space />
+                <key key="golf" value="fairway" match="keyvalue!" />
+                <key key="surface" value="grass" />
+            </item> <!-- Fairway -->
+        </group> <!-- Golf -->
         <item name="Stadium" icon="styles/standard/sport/stadium.png" type="node,closedway" preset_name_label="true">
             <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=stadium"
                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=stadium"
@@ -5053 +5140 @@
             <text key="name" text="Name" />
             <combo key="sport" text="Sport" values="athletics,cycling,dog_racing,equestrian,horse_racing,running,skating" values_context="sport" />
         </item> <!-- Racetrack -->
-        <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
-                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
-                  es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
-                  fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
-                  ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
-                  pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
-                  pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
-            <space />
-            <key key="leisure" value="golf_course" />
-            <reference ref="name_oh_wheelchair" />
-        </item> <!-- Golf Course -->
-        <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
-            <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
-                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
-                  es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
-                  ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
-                  pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
-                  ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
-            <space />
-            <key key="leisure" value="miniature_golf" />
-            <reference ref="name_oh_wheelchair" />
-        </item> <!-- Miniature Golf -->
     </group> <!-- Sport Facilities -->
     <group name="Sport" icon="presets/rowing.png">
         <item name="Multi" icon="styles/standard/sport/multi.png" type="node,closedway" preset_name_label="true">

[Don-vip]

In 9322/josm:

see #12240 - add taginfo test for popular tags - ignore unknown tags until their fate is decided (added, ignored, or deprecated)

[Klumbumbus]

In 9425/josm:

see #12240 - add seasonal=yes to waterways and wetland, adjust intermittent; move ignored tags