Imagery tiles that don't load sometimes can't be force reloaded via 'Load All Error Tiles' anymore

[rickmastfan67]

This happens sometimes when a Bing Imagery tile for some reason doesn't get a URL because of an 'attribution' problem, even though the attribution was already loaded supposedly.

INFO: Successfully loaded Bing attribution data.
Bing: attribution data is not yet loaded.
WARNING: JCS TMS Cache - error creating URL for tile 19/145888/197713@Bing Sat:
Attribution is not loaded yet
INFO: Exception:
WARNING: No url returned for: Bing Sat:http://www.bing.com/maps/19/145888/197713, skipping

The only way to force this tile to finally download is to delete the Bing layer, and then reopen Bing. Before the new cache functions were added to JOSM, all I had to do when there was an 'attribution' problem with Bing preventing the tiles from loading, was to hit the 'Load All Error Tiles' in the right click menu to get the images to load.

So, any fix for this to prevent having to delete the Bing imagery layer and reactivate it would be greatly appreciated to restore the old functionality.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-08-09 01:33:01
Last Changed Author: wiktorn
Revision: 8651
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-08-08 19:58:08 +0200 (Sat, 08 Aug 2015)
Last Changed Rev: 8651

Identification: JOSM/1.5 (8651 en) Windows 7 64-Bit
Memory Usage: 380 MB / 1820 MB (131 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- OpeningHoursEditor (31241)
- buildings_tools (31361)
- measurement (31289)
- mirrored_download (31294)
- osmarender (31241)
- reverter (31241)
- turnrestrictions (31241)
- undelete (31241)
- utilsplugin2 (31463)

[rickmastfan67]

Looks like #11555 could be related.

[rickmastfan67]

So, as far as I can tell, the 'error' message isn't being passed along to the 'imagery' layer (meaning the red 'error' text isn't showing up). I think that's where the 'Load All Error Tiles' function gets confused since it doesn't know there is an error there because of the lack of that error text.

Maybe in this case when Bing has this problem, maybe we could have JOSM automatically try a second time to load the image? I mean, most of the time, the attribution data has been loaded, but JOSM gets a tad confused and though that it wasn't loaded on 1 or 2 tiles.

[wiktorn]

In 8673/josm:

Bing fixes.

• Pass and handle error on url creation (attribution not loaded yet). Closes: #11776
• Properly identify "no tiles at this zoom level" situation in tile sets. This tiles are never marked as loaded. Closes: #11785