Modify

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#11687 closed enhancement (fixed)

[patch] Please implement {epsg} in WMS request template

Reported by: A_Pirard Owned by: team
Priority: normal Milestone:
Component: Core imagery Version: tested
Keywords: ArcGis wms projection epgs Cc:

Description

Please implement {epsg} (or equivalent name) in http: request template
That's the same as {projection}, but without "EPSG:".
That will help building an ArcGis request.
ex: &imageSR={epsg} giving &imageSR=3857

TIA!!!

Attachments (1)

11687.patch (1.6 KB) - added by slodki 3 years ago.
new parameter {epsg} added

Download all attachments as: .zip

Change History (17)

comment:1 Changed 4 years ago by bastiK

Esri keeps a separate list of projection ids and calls it well-known ID. It is mostly identical with EPSG, but the reason they forked it, is probably to allow changes and additions.

We should name the prarameter {wkid}, see here for a description of the imageSR parameter.

comment:2 Changed 4 years ago by simon04

Keywords: wms projection epgs added; request helper removed
Summary: Please implement {epsg} in http: request templatePlease implement {epsg} in WMS request template

comment:3 Changed 3 years ago by bastiK

Ticket #12527 has been marked as a duplicate of this ticket.

comment:4 Changed 3 years ago by wiktorn

Component: CoreCore imagery

Changed 3 years ago by slodki

Attachment: 11687.patch added

new parameter {epsg} added

comment:5 Changed 3 years ago by slodki

Summary: Please implement {epsg} in WMS request template[patch] Please implement {epsg} in WMS request template

Patch not tested. Please review.

comment:6 Changed 3 years ago by wiktorn

Resolution: fixed
Status: newclosed

In 9864/josm:

Add WKID (Well Known ID) pattern to WMS url templates.

Patch by: slodki

Closes: #11687

comment:7 Changed 3 years ago by wiktorn

@slodki: thanks for you contribution.

I changed the name of the parameter to {wkid} as bastiK proposed.

comment:8 in reply to:  7 ; Changed 3 years ago by slodki

@wiktorn: it's bad idea to fallback to myProjCode - wkid is number and myProjCode can be "CRS:84" etc. Final result for JOSM user should be similar (http error), but empty string is better for undefined value then some strange string.
I've compared epsg database dump with Esri wkid list - it seems all wkid numbers <53000 have similar epsg numbers registered (i haven't compared proj definitions):

  • 7407 numbers only in epsg database
  • 3848 numbers in both epsg & ersi
  • 1037 numbers only on wkid list

My code returns:

  • *epsg* number = wkid for some projections
  • *epsg* number even if it's not registered as wkid by Ersi (unknown wkid)
  • empty string (nothing) for projections not identified by epsg code

Your code returns:

  • *wkid* = epsg for some projections
  • epsg, *not wkid*, for some projections not registered as wkid by Ersi
  • string, *not wkid*, for projections not identified by epsg code

So {wkid} parameter name could be misleading - JOSM knows nothing about Ersi wkid list so far, except some similarities to epsg ids.

comment:9 in reply to:  8 Changed 3 years ago by bastiK

Replying to slodki:

So {wkid} parameter name could be misleading - JOSM knows nothing about Ersi wkid list so far, except some similarities to epsg ids.

Nevertheless, this is specifically for compatibility with Esri software. We can add more details and workarounds as needed. We can even ship the complete list, should it be necessary.

comment:10 Changed 3 years ago by slodki

"CRS:84" is correct value for {wkid}? Can it be mapped to ArcGIS ID?
How many projections (as returned by myProjCode) without "epsg:" prefix do we use in JOSM?

comment:11 in reply to:  10 Changed 3 years ago by bastiK

Replying to slodki:

"CRS:84" is correct value for {wkid}? Can it be mapped to ArcGIS ID?

You can ignore "CRS:84", it is only relevant for WMS version 1.3.0. The equivalent EPSG code is EPSG:4326.

How many projections (as returned by myProjCode) without "epsg:" prefix do we use in JOSM?

This is the only one at the moment.

comment:12 Changed 3 years ago by anonymous

In my mind, {epsg} is the EPSG number taken out of what I call the screen projection (to make it newbie understandable).
It is not an Arcgis feature properly, but it's useful to hack its request better than by hardcoding that projection.

When can I start testing and how?
Shouldn't this bug be reopened and closed as a gignal?

comment:13 in reply to:  12 ; Changed 3 years ago by bastiK

Replying to anonymous:

In my mind, {epsg} is the EPSG number taken out of what I call the screen projection (to make it newbie understandable).
It is not an Arcgis feature properly, but it's useful to hack its request better than by hardcoding that projection.

Sure, one could do that. Or, as this hack would be useful for nothing else, go one step further and treat it as a feature for Arcgis compatibility. At the moment, it is practically the same, just the name is different.

When can I start testing and how?

Now, by downloading the latest version of JOSM.

Shouldn't this bug be reopened and closed as a gignal?

Closed as what?

comment:14 in reply to:  13 ; Changed 3 years ago by A_Pirard

I wish this site really remembered me.

Replying to bastiK:

Replying to anonymous:

When can I start testing and how?

Now, by downloading the latest version of JOSM.

That's "when". What about "how": epsg or wkid. not clear.

Shouldn't this bug be reopened and closed as a gignal?

Closed as what?

closed and reopened as a signal.

comment:15 in reply to:  14 Changed 3 years ago by wiktorn

Replying to A_Pirard:

Replying to bastiK:

Replying to anonymous:

When can I start testing and how?

Now, by downloading the latest version of JOSM.

That's "when". What about "how": epsg or wkid. not clear.

Use {wkid}. It's already documented here.

comment:16 Changed 3 years ago by A_Pirard

I changed 3857 to {wkid} in a layer definition and it seems alright to me.
Just as great JOSM as ever!!! Many thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.