Modify

Opened 5 years ago

Closed 5 years ago

#11686 closed defect (fixed)

[Patch] Error by uploading changeset with too long tag

Reported by: edward17@… Owned by: edward17
Priority: normal Milestone: 15.09
Component: Core Version: tested
Keywords: template_report changeset tag length Cc:

Description

What steps will reproduce the problem?

  1. Click on "Upload changes" button
  2. In dialog, select the "New changeset's tags"
  3. Add new tag
  4. Enter very long value

What is the expected result?

JOSM must say that this value is too long and cannot be uploaded on server.

What happens instead?

An error occur, log is below.

Please provide any additional information below. Attach a screenshot if possible.

  1. S. Excuse me my bad English. I can speak German better than English (hovever you can also speak German).

Excuse me if I have entered some information in wrong field.
Excuse me if resembling issue already exists.

If you have any questions, I can answer them.
My OSM-user profile is here: http://www.openstreetmap.org/user/edward17/ You can send me OSM-message.

Revision: 8491
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2015-06-16 23:27:08 +0200 (Tue, 16 Jun 2015)
Build-Date: 2015-06-16 21:45:58
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8491

Identification: JOSM/1.5 (8491 ru) Windows 7 64-Bit
Memory Usage: 247 MB / 247 MB (7 MB allocated, but free)
Java version: 1.8.0_31, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugins:
- PicLayer (31241)
- buildings_tools (31241)
- imagery_offset_db (31241)
- jts (31126)
- measurement (31289)
- scripting (30710)

Last errors/warnings:
- E: java.lang.IllegalArgumentException: Changeset tag value is too long: В Горловке улицы Узловская, Маршала Пересыпкина, Кузнецова-Зубарева и участок от Кузнецова-Зубарева до проспекта Ленина в реальности имеют одну проезжую часть (с двойной сплошной линией). Поэтому они должны быть обозначены в OSM одной линией, а не двумя, как сейчас. Из-за того, что по ним проходит очень много маршрутов общественного транспорта, я не стал их трогать. Но надеюсь, что когда-нибудь это будет исправлено.

java.lang.IllegalArgumentException: Changeset tag value is too long: В Горловке улицы Узловская, Маршала Пересыпкина, Кузнецова-Зубарева и участок от Кузнецова-Зубарева до проспекта Ленина в реальности имеют одну проезжую часть (с двойной сплошной линией). Поэтому они должны быть обозначены в OSM одной линией, а не двумя, как сейчас. Из-за того, что по ним проходит очень много маршрутов общественного транспорта, я не стал их трогать. Но надеюсь, что когда-нибудь это будет исправлено.
	at org.openstreetmap.josm.data.osm.Changeset.setKeys(Changeset.java:197)
	at org.openstreetmap.josm.gui.io.UploadDialog.getChangeset(UploadDialog.java:300)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:263)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:287)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (1)

11686.patch (5.7 KB) - added by simon04 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by Don-vip

Keywords: changeset tag length added
Milestone: 15.07

comment:2 Changed 5 years ago by Don-vip

Milestone: 15.0715.08

Milestone renamed

comment:3 Changed 5 years ago by Don-vip

Cc: edward17@… removed
Milestone: 15.0815.09

Changed 5 years ago by simon04

Attachment: 11686.patch added

comment:4 Changed 5 years ago by simon04

Summary: Error by uploading changeset with too long tag[Patch] Error by uploading changeset with too long tag

attachment:11686.patch​ disallows longer keys/values in changeset tag table. The plugin tageditor needs adoption afterwards. Is there a more elegant solution to restrict the length?

comment:5 Changed 5 years ago by simon04

Resolution: fixed
Status: newclosed

In 8760/josm:

fix #11686 - Error by uploading changeset with too long tag

Changeset tags table: limit key/value length to allowed maximum of API

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain edward17.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.