Incoherent note list behavior after notes download

[jbcorbeille-josm@…]

What steps will reproduce the problem?

1. Download some notes.
2. Interact with these notes, for example, close one note
3. Change zone, download new notes
4. Double click on the first note on the list (notes panel). If this note was just downloaded, the focus does not happen on this one, but on the first one that was already present before the last download.

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Revision: 8507
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: simon04
Last Changed Date: 2015-06-20 00:27:53 +0200 (Sat, 20 Jun 2015)
Build-Date: 2015-06-20 01:32:19
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8507

Identification: JOSM/1.5 (8507 fr) Windows 7 64-Bit
Memory Usage: 243 MB / 247 MB (130 MB allocated, but free)
Java version: 1.8.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
- DirectUpload (31241)
- cadastre-fr (31241)
- continuosDownload (1413902943)
- download_along (31241)
- geotools (31126)
- jts (31126)
- mirrored_download (31287)
- poly (31241)
- reltoolbox (31241)
- reverter (31241)
- scripting (30710)
- utilsplugin2 (31241)

Last errors/warnings:
- W: JCS TMS - error loading object for tile 13/4187/2837@Bano: Error reading PNG metadata
- W: JCS TMS - error loading object for tile 13/4187/2837@Bano: Error reading PNG metadata
- W: JCS TMS - error loading object for tile 13/4187/2837@Bano: Error reading PNG metadata
- W: JCS TMS - error loading object for tile 13/4187/2837@Bano: Error reading PNG metadata
- W: JCS TMS - error loading object for tile 13/4187/2837@Bano: Error reading PNG metadata

[Don-vip]

Can't reproduce, can you please check if the problem still occurs in r13115?

[Klumbumbus]

I can reproduce. Steps:

1. download notes
2. open tooltip of a note in the list and let it stay open (the note is selected in the list)
3. download more notes
4. see how the selection in the list stays at the 1st, 2nd or 3rd note in the list, dependend on which you selected at the beginning, however the 1st, 2nd and 3rd note are now other notes. Here is the bug already.
5. (double click on the already selected note in the list)
6. (it jumps to the still open tooltip)

[NoteRoamer]

I am unable to reproduce this. I have tried with different areas, different sorting, and selecting different positions in the list. The tooltip stays open on the previously selected note, the highlight stays on the previously selected note and the note might change position depending on the sorting.

Since this ticket was opened several changes have been made both to the dialog and the underlying classes so my guess is something fixed it along the way.

[taylor.smock]

Fixed after r18458 but before r18480. Probably r18479 (#21600).

[taylor.smock]

@NoteRoamer: Thanks for seeing that this ticket was fixed. I need to go through the ticket backlog and find stuff that is already fixed, but which we don't know is fixed.

[NoteRoamer]

Replying to taylor.smock:

@NoteRoamer: Thanks for seeing that this ticket was fixed. I need to go through the ticket backlog and find stuff that is already fixed, but which we don't know is fixed.

Happy to help, thanks for the fast reaction.

[taylor.smock]

No problem. I'm currently the most active JOSM contributor (most everyone else does one or two contributions a month), and I don't have time to go through old tickets and figure out which one(s) have already been fixed.

[gaben]

Replying to taylor.smock:

Probably r18479 (#21600).

Yep, probably there.