Opened 10 years ago
Closed 10 years ago
#11538 closed defect (othersoftware)
no validation warning on 3-letter weekdays in opening_hours
Reported by: | aceman | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | latest |
Keywords: | Cc: | ypid23 |
Description
The validator does not produce a warning on opening_hours values containing 3-letter weekdays abbreviations and even mixed 2-letter and 3-letter intervals. Also there is no warning about the colons after weekdays.
E.g.
opening_hours=Mo-Fri: 7:00-18:00, Sat: 7:00-13:00
I get no warning.
The wiki http://wiki.openstreetmap.org/wiki/Key:opening_hours does not mention the 3-letter abbreviations as valid.
I know JOSM uses an external library to check the syntax. So if this is a problem in the library, please forward to the author.
Attachments (0)
Change History (5)
comment:1 by , 10 years ago
Cc: | added |
---|
comment:2 by , 10 years ago
comment:3 by , 10 years ago
comment:4 by , 10 years ago
Yeah, if the string is rewritten with ; separator "Mo-Fri: 7:00-18:00; Sat: 7:00-13:00", the tool gives proper warnings. ; should be fine in this case instead of , . So it really seems a bug in parsing the , separator.
comment:5 by , 10 years ago
Resolution: | → othersoftware |
---|---|
Status: | new → closed |
If I use the validator tool linked from the wiki (http://ypid.de/~osm/evaluation_tool/) on a string of "Mo-Fri: 7:00-18:00" it does produce warnings:
Mo-Fri <--- (Please use the abbreviation "Fr" for "fri".)
Mo-Fri: <--- (You have used the optional symbol <separator_for_readability> in the wrong place. Please check the syntax specification to see where it could be used or remove it.)
And it prettifies to "Mo-Fr 07:00-18:00" (notice the added leading 0), which is correct.
But if inputting the full string of "Mo-Fri: 7:00-18:00, Sat: 7:00-13:00" the tool is silent too, no warnings and no output.