Opened 4 years ago

Closed 3 years ago

#11538 closed defect (othersoftware)

no validation warning on 3-letter weekdays in opening_hours

Reported by: aceman Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: Cc: ypid23


The validator does not produce a warning on opening_hours values containing 3-letter weekdays abbreviations and even mixed 2-letter and 3-letter intervals. Also there is no warning about the colons after weekdays.
opening_hours=Mo-Fri: 7:00-18:00, Sat: 7:00-13:00

I get no warning.

The wiki does not mention the 3-letter abbreviations as valid.

I know JOSM uses an external library to check the syntax. So if this is a problem in the library, please forward to the author.

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by Klumbumbus

Cc: ypid23 added

comment:2 Changed 4 years ago by aceman

If I use the validator tool linked from the wiki ( on a string of "Mo-Fri: 7:00-18:00" it does produce warnings:
Mo-Fri <--- (Please use the abbreviation "Fr" for "fri".)
Mo-Fri: <--- (You have used the optional symbol <separator_for_readability> in the wrong place. Please check the syntax specification to see where it could be used or remove it.)

And it prettifies to "Mo-Fr 07:00-18:00" (notice the added leading 0), which is correct.

But if inputting the full string of "Mo-Fri: 7:00-18:00, Sat: 7:00-13:00" the tool is silent too, no warnings and no output.

comment:3 Changed 4 years ago by ypid23


The problem is already known upstream (see issue #86). I already tried to fix this but it is not that trivial. I hope I can fix this in the next release.

Last edited 4 years ago by ypid23 (previous) (diff)

comment:4 Changed 4 years ago by aceman

Yeah, if the string is rewritten with ; separator "Mo-Fri: 7:00-18:00; Sat: 7:00-13:00", the tool gives proper warnings. ; should be fine in this case instead of , . So it really seems a bug in parsing the , separator.

comment:5 Changed 3 years ago by simon04

Resolution: othersoftware
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.