Alternative name without name warning in irrelevant cases

[jbohmdk]

What steps will reproduce the problem? ¶

1. Edit a node with a tag other than name, such as name:1971-2013, osak:municipality_name or osak:street_name
2. Try to upload the change
3. Get a warning about alternative name without name

What is the expected result? ¶

No warning about this

What happens instead? ¶

Warning about "alternative name without name"

Please provide any additional information below. Attach a screenshot if possible. ¶

This did not happen in r7777.

I suspect someone changed the code to match any attribute with substring "name", thus causing spurious warnings for lots of common cases. For example "municipality_name" and "street_name" are part of the official address data on more than 1 million nodes in Denmark, while name:year-year is part of the general scheme for tagging former attributes of nodes that now have other uses/no use and thus no name.

Example nodes (my only edits this morning): 340636013 and 340660662

This may be similar to the earlier bug (already fixed) about artist_name

Revision: 8339
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: stoecker
Last Changed Date: 2015-05-07 17:30:43 +0200 (Thu, 07 May 2015)
Build-Date: 2015-05-08 01:31:23
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8339

Identification: JOSM/1.5 (8339 en) Windows 7 64-Bit
Memory Usage: 224 MB / 455 MB (85 MB allocated, but free)
Java version: 1.8.0_45, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- DirectUpload (30892)
- ElevationProfile (31089)
- editgpx (30892)
- reverter (31120)

[jbohmdk]

Correction: I found that this was introduced in r7818 in combinations.mapcss. It matches all but a few attributes ending in _name, even after a colon (so name:year-year is not an issue as I originally suspected). While adding additional exceptions as bugs comes in, it might be more practical to check the online tag search engines to see which existing tags should/should not trigger this, then decide if a positive or negative match list is the best approach.

[Klumbumbus]

In 8480/josm:

fix #11539 - do not warn about alternitive names osak:municipality_name and osak:street_name