Support setting changeset tags during /import call

[StefanB]

It would make much sense to specify source tag for the changeset during /import remote control call

I know it can be set on load_and_zoom, but that requires exact bbox as a parameter and calling that would prevent users from inspecting the imported data before it is merged with existing data downloaded via API.

It can also support setting changeset comment, but source tag is the most crucial one for imports.

[StefanB]

Ooops, probably a duplicate of #11045. Didn't remember mentioning this in a comment there.

[simon04]

Since the data is loaded from an OSM file, the changeset comment could be specified there:

<osm version='0.6' upload='true' generator='JOSM'>
  <changeset><tag k="comment" v="This will show up when uploading"/></changeset>
  <!-- ... -->
</osm>

[anonymous]

Thanks for a nice hint, but we're importing zipped shapefiles, not .osm xml files.

[anonymous]

We could in theory use OpenData plugin to convert all the shapefiles to OSM xml format in the data preparation phase, but I don't know yet how to do that in a script.

[StefanB]

Would it be possible to use zip file comment or some ShapeFile comment (if it exists at all, not sure)? Or a text file within in zip? Extra import parameter would be easiest, i guess.

[StefanB]

The recently closed #18038 "[PATCH] Arbitrary changeset tags should be able to be added via remote control" gave me some hope, but unfortunately the changeset_tags parameter is only applicable for /load_and_zoom command.

Our import project (​https://raba.openstreetmap.si/) could really use the changeset_source (and optionally changeset_comment) or just a generic changeset_tags also on the /import remote control API command to specify the source of the import.

The changeset_source parameter could also be required for all /import calls, as any import should specify the source!

[taylor.smock]

Initial quick and dirty patch. Needs deduplication of code (for changeset_tags) and parseUrlTagsToKeyValues should probably be moved to RequestHandler.

[simon04]

In 16324/josm:

fix #11310 - Support setting changeset tags during /import call

[stoecker]

I'm pretty sure there is a wiki page where changes to remote control should be documented.

[Klumbumbus]

wiki:/Help/Preferences/RemoteControl
wiki:/Help/RemoteControlCommands

[simon04]

Thanks. Done via Help/RemoteControlCommands?action=diff&version=13

[StefanB]

Great, thanks!

Can you please add this also to the:

• import
• load_data
• open_file

...and possibly other calls?
Or just make a separate call just for that.

It is needed there to set source tags and meaningful comments.

[Don-vip]

I'm working on a refactoring of remote control parameters handling to share parameters between different handlers.

[StefanB]

That would be great, and would simplify the API considerably. Thanks!

[Klumbumbus]

Milestone renamed